Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Unified Diff: Source/devtools/front_end/timeline/TimelineFlameChart.js

Issue 318093002: Convert timestamp to milliseconds when creating TracingModel.Event (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/devtools/front_end/timeline/TimelineFlameChart.js
diff --git a/Source/devtools/front_end/timeline/TimelineFlameChart.js b/Source/devtools/front_end/timeline/TimelineFlameChart.js
index 9df14e35ac35d7db201e67acee510f3183397630..73b84602a482e5b487067af15cebc620f71064b4 100644
--- a/Source/devtools/front_end/timeline/TimelineFlameChart.js
+++ b/Source/devtools/front_end/timeline/TimelineFlameChart.js
@@ -576,7 +576,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
minimumBoundary: function()
{
- return this._toTimelineTime(this._minimumBoundary);
+ return this._minimumBoundary;
},
/**
@@ -584,7 +584,7 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
*/
totalTime: function()
{
- return this._toTimelineTime(this._timeSpan);
+ return this._timeSpan;
},
/**
@@ -698,8 +698,8 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
if (!event)
return null;
return {
- startTime: this._toTimelineTime(event.startTime),
- endTime: this._toTimelineTime(event.endTime)
+ startTime: event.startTime,
+ endTime: event.endTime
}
},
@@ -729,8 +729,8 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
this._entryIndexToTitle[index] = title;
this._entryEvents.push(null);
this._timelineData.entryLevels[index] = this._currentLevel++;
- this._timelineData.entryTotalTimes[index] = this._toTimelineTime(this._timeSpan);
- this._timelineData.entryStartTimes[index] = this._toTimelineTime(this._minimumBoundary);
+ this._timelineData.entryTotalTimes[index] = this._timeSpan;
+ this._timelineData.entryStartTimes[index] = this._minimumBoundary;
},
/**
@@ -741,17 +741,8 @@ WebInspector.TracingBasedTimelineFlameChartDataProvider.prototype = {
var index = this._entryEvents.length;
this._entryEvents.push(event);
this._timelineData.entryLevels[index] = this._currentLevel + event.level;
- this._timelineData.entryTotalTimes[index] = this._toTimelineTime(event.duration || 1000);
- this._timelineData.entryStartTimes[index] = this._toTimelineTime(event.startTime);
- },
-
- /**
- * @param {number} time
- * @return {number}
- */
- _toTimelineTime: function(time)
- {
- return time / 1000;
+ this._timelineData.entryTotalTimes[index] = event.duration || 1;
+ this._timelineData.entryStartTimes[index] = event.startTime;
},
/**
« no previous file with comments | « LayoutTests/inspector/timeline/trace-event-self-time.html ('k') | Source/devtools/front_end/timeline/TimelineFrameModel.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698