Issue 318093002: Convert timestamp to milliseconds when creating TracingModel.Event

Issue 318093002: Convert timestamp to milliseconds when creating TracingModel.Event (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
caseq, alph, pfeldman, loislo

CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, malch+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, aandrey+blink_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Convert timestamp to milliseconds when creating TracingModel.Event Timeline uses time in milliseconds while trace event use microseconds. Do the conversion earlier. BUG=361045 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175746

Patch Set 1 #

Patch Set 2 : #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -63 lines)			Patch
M	LayoutTests/inspector/timeline/trace-event-self-time.html	View	1	11 chunks	+14 lines, -14 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFlameChart.js	View		5 chunks	+8 lines, -17 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineFrameModel.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineModel.js	View		3 chunks	+3 lines, -3 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TimelineTracingView.js	View	1	7 chunks	+11 lines, -20 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingModel.js	View		4 chunks	+4 lines, -4 lines	0 comments	Download
M	Source/devtools/front_end/timeline/TracingTimelineUIUtils.js	View		3 chunks	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

yurys

I'm not sure this is a right approach. I'd rather use microseconds everywhere to keep ...

6 years, 6 months ago (2014-06-06 14:56:51 UTC) #1

caseq

lgtm I think milliseconds are fine. We've had "the best unit for representing time" debate ...

6 years, 6 months ago (2014-06-06 15:49:07 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/318093002/20001

6 years, 6 months ago (2014-06-07 15:14:44 UTC) #4

Message was sent while issue was closed.

Change committed as 175746

Expand Messages | Collapse Messages