Issue 318033002: Minor additions to GN build, comment mojo bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318033002: Minor additions to GN build, comment mojo bindings. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 4 months ago

Reviewers:
yzshen1

CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, viettrungluu+watch_chromium.org, qsr+mojo_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, yzshen+watch_chromium.org, horo+watch_chromium.org, darin (slow to review), ben+mojo_chromium.org, alecflett+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Minor additions to GN build, comment mojo bindings. This adds comments for the converted mojo targets listing where the GN versions were. I went to implement them and I found I already did them, but couldn't find them. This adds some protobuf builds also used by content/browser, as well as a Windows warning fix for the protobuf compiler. R=yzshen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275827

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	BUILD.gn	View	1	2 chunks	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

brettw

6 years, 6 months ago (2014-06-09 17:13:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r275827 (presubmit successful).

Expand Messages | Collapse Messages

Issue 318033002: Minor additions to GN build, comment mojo bindings. (Closed)

Description

Patch Set 1 #

Patch Set 2 : no android #

Patch Set 3 : #

Messages