Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(522)

Issue 318013003: Reverted !client_id check because it caused unit test failure. (Closed)

Created:
6 years, 6 months ago by pkl (ping after 24h if needed)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Reverted !client_id check because it caused unit test failure. Reverted code back to what it was and removed DCHECK that is no longer necessary BUG=383745 TBR=rohitrao Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276670

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M base/ios/device_util.mm View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
pkl (ping after 24h if needed)
Shouldn't have added that extra test in the first place. Looks like unit tests depended ...
6 years, 6 months ago (2014-06-06 16:06:41 UTC) #1
sdefresne
lgtm
6 years, 6 months ago (2014-06-06 20:22:17 UTC) #2
pkl (ping after 24h if needed)
rohitrao: ping!
6 years, 6 months ago (2014-06-12 08:22:51 UTC) #3
pkl (ping after 24h if needed)
The CQ bit was checked by pkl@chromium.org
6 years, 6 months ago (2014-06-12 08:45:48 UTC) #4
sdefresne
The CQ bit was checked by sdefresne@chromium.org
6 years, 6 months ago (2014-06-12 08:45:52 UTC) #5
pkl (ping after 24h if needed)
TBR=rohitrao for OWNERS
6 years, 6 months ago (2014-06-12 08:47:24 UTC) #6
pkl (ping after 24h if needed)
Hi Rohit! Please take a look.
6 years, 6 months ago (2014-06-12 08:48:03 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkl@chromium.org/318013003/1
6 years, 6 months ago (2014-06-12 08:49:00 UTC) #8
rohitrao (ping after 24h)
Whoops, sorry, lost this in my inbox. LGTM
6 years, 6 months ago (2014-06-12 12:16:06 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 14:28:24 UTC) #10
Message was sent while issue was closed.
Change committed as 276670

Powered by Google App Engine
This is Rietveld 408576698