Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issue 318013002: Implement EmbeddedSharedWorkerPermissionClientProxy. (Closed)

Created:
6 years, 6 months ago by horo
Modified:
6 years, 6 months ago
Reviewers:
Xi Han, nhiroki
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Implement EmbeddedSharedWorkerPermissionClientProxy. embedded_shared_worker_permission_client_proxy.* are copied from shared_worker_permission_client_proxy.* in content/worker/. I will delete the directory when we will stop using worker process. BUG=327256 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275768

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -22 lines) Patch
M content/content_renderer.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
A + content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.h View 3 chunks +7 lines, -7 lines 0 comments Download
A + content/renderer/shared_worker/embedded_shared_worker_permission_client_proxy.cc View 3 chunks +14 lines, -13 lines 0 comments Download
M content/renderer/shared_worker/embedded_shared_worker_stub.cc View 2 chunks +7 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
horo
hanxi@ Could you please review this? Thank you.
6 years, 6 months ago (2014-06-06 04:58:14 UTC) #1
Xi Han
lgtm
6 years, 6 months ago (2014-06-06 15:10:21 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/318013002/1
6 years, 6 months ago (2014-06-06 15:11:11 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 15:11:11 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 6 months ago (2014-06-06 15:11:12 UTC) #5
horo
nhiroki@ Could you please review?
6 years, 6 months ago (2014-06-09 01:05:03 UTC) #6
nhiroki
lgtm
6 years, 6 months ago (2014-06-09 01:48:45 UTC) #7
horo
The CQ bit was checked by horo@chromium.org
6 years, 6 months ago (2014-06-09 02:06:17 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/318013002/1
6 years, 6 months ago (2014-06-09 02:07:12 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 05:01:01 UTC) #10
Message was sent while issue was closed.
Change committed as 275768

Powered by Google App Engine
This is Rietveld 408576698