Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 318003003: Remove //content and //chrome dependencies from MetricsLog unittest (Closed)

Created:
6 years, 6 months ago by blundell
Modified:
6 years, 6 months ago
CC:
chromium-reviews, Ilya Sherman, asvitkine+watch_chromium.org, jar+watch_chromium.org
Visibility:
Public.

Description

Remove //content and //chrome dependencies from MetricsLog unittest Most of these includes were stale. Merging of this suite of unittests with that in //components/metrics/metrics_log_unittest.cc is left for a followup CL. BUG=382549 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276010

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -27 lines) Patch
M chrome/browser/metrics/metrics_log_unittest.cc View 3 chunks +4 lines, -27 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
blundell
6 years, 6 months ago (2014-06-09 17:20:26 UTC) #1
Alexei Svitkine (slow)
LGTM
6 years, 6 months ago (2014-06-09 17:36:58 UTC) #2
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-09 17:45:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/318003003/1
6 years, 6 months ago (2014-06-09 17:47:38 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 08:56:20 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:01:01 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150225)
6 years, 6 months ago (2014-06-10 12:01:02 UTC) #7
blundell
The CQ bit was checked by blundell@chromium.org
6 years, 6 months ago (2014-06-10 13:05:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/blundell@chromium.org/318003003/1
6 years, 6 months ago (2014-06-10 13:07:32 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-10 13:38:51 UTC) #10
Message was sent while issue was closed.
Change committed as 276010

Powered by Google App Engine
This is Rietveld 408576698