Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(306)

Issue 318003002: Rename methods in ResourceFetcher to describe what's done in them correctly (Closed)

Created:
6 years, 6 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 6 months ago
Reviewers:
Nate Chapin
CC:
blink-reviews, Nate Chapin, gavinp+loader_chromium.org
Visibility:
Public.

Description

Rename methods in ResourceFetcher to describe what's done in them correctly loadRequest() was calling load() before http://trac.webkit.org/changeset/129462 but no longer calling it. The same about revalidateResource(). Give them new names describing what's done in them. Also, this CL makes some style fix in them. BUG=none R=japhet Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175767

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed #2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M Source/core/fetch/ResourceFetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 4 chunks +10 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 6 months ago (2014-06-06 02:08:35 UTC) #1
Nate Chapin
LGTM https://codereview.chromium.org/318003002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/318003002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode851 Source/core/fetch/ResourceFetcher.cpp:851: Why the newlines here and below?
6 years, 6 months ago (2014-06-06 16:16:31 UTC) #2
tyoshino (SeeGerritForStatus)
-yhirano https://codereview.chromium.org/318003002/diff/1/Source/core/fetch/ResourceFetcher.cpp File Source/core/fetch/ResourceFetcher.cpp (right): https://codereview.chromium.org/318003002/diff/1/Source/core/fetch/ResourceFetcher.cpp#newcode851 Source/core/fetch/ResourceFetcher.cpp:851: On 2014/06/06 16:16:31, Nate Chapin wrote: > Why ...
6 years, 6 months ago (2014-06-09 02:03:32 UTC) #3
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 6 months ago (2014-06-09 02:03:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/318003002/20001
6 years, 6 months ago (2014-06-09 02:04:06 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 03:06:55 UTC) #6
Message was sent while issue was closed.
Change committed as 175767

Powered by Google App Engine
This is Rietveld 408576698