Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(87)

Issue 317973004: Allocate SharedBitmaps on FILE_USER_BLOCKING thread. (Closed)

Created:
6 years, 6 months ago by jbauman
Modified:
6 years, 6 months ago
Reviewers:
piman
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Allocate SharedBitmaps on FILE_USER_BLOCKING thread. Allocating these can be expensive (especially on OS X) so it's best not to block the IO thread while doing that. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276358

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -7 lines) Patch
M content/browser/renderer_host/render_message_filter.h View 1 1 chunk +4 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_message_filter.cc View 1 3 chunks +23 lines, -6 lines 2 comments Download

Messages

Total messages: 7 (0 generated)
jbauman
6 years, 6 months ago (2014-06-06 23:25:47 UTC) #1
piman
https://codereview.chromium.org/317973004/diff/20001/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/317973004/diff/20001/content/browser/renderer_host/render_message_filter.cc#newcode331 content/browser/renderer_host/render_message_filter.cc:331: // This function should be called on the IO ...
6 years, 6 months ago (2014-06-09 18:35:05 UTC) #2
jbauman
https://codereview.chromium.org/317973004/diff/20001/content/browser/renderer_host/render_message_filter.cc File content/browser/renderer_host/render_message_filter.cc (right): https://codereview.chromium.org/317973004/diff/20001/content/browser/renderer_host/render_message_filter.cc#newcode331 content/browser/renderer_host/render_message_filter.cc:331: // This function should be called on the IO ...
6 years, 6 months ago (2014-06-09 19:22:26 UTC) #3
piman
I see, ok. I'm not super excited about flaky leaks (FILE_USER_BLOCKING outlives the IO thread), ...
6 years, 6 months ago (2014-06-10 00:41:04 UTC) #4
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-06-10 16:59:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/317973004/20001
6 years, 6 months ago (2014-06-10 17:02:24 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 11:59:36 UTC) #7
Message was sent while issue was closed.
Change committed as 276358

Powered by Google App Engine
This is Rietveld 408576698