Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(310)

Issue 317963004: Re-land Clusterfuzz identified overflow check needed in dehoisting. (Closed)

Created:
6 years, 6 months ago by mvstanton
Modified:
6 years, 6 months ago
Reviewers:
danno-g, danno
CC:
v8-dev
Visibility:
Public.

Description

Re-land Clusterfuzz identified overflow check needed in dehoisting. Overflow check needs to be smarter. BUG=380092 R=danno@google.com, danno@chromium.org LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21712

Patch Set 1 #

Patch Set 2 : Bugfix, use arithmetic shift instead of divide. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -33 lines) Patch
M src/hydrogen-dehoist.cc View 1 1 chunk +15 lines, -5 lines 0 comments Download
M src/hydrogen-instructions.h View 5 chunks +29 lines, -15 lines 0 comments Download
A + test/mjsunit/regress/regress-380092.js View 1 chunk +6 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
danno-g
lgtm
6 years, 6 months ago (2014-06-06 12:57:34 UTC) #1
mvstanton
6 years, 6 months ago (2014-06-06 13:00:21 UTC) #2
Message was sent while issue was closed.
Committed patchset #2 manually as r21712.

Powered by Google App Engine
This is Rietveld 408576698