Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 317963003: Disable mirror cache when initializing DebuggerScript.js (Closed)

Created:
6 years, 6 months ago by yurys
Modified:
6 years, 6 months ago
Reviewers:
aandrey, Yang, loislo
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, abarth-chromium
Visibility:
Public.

Description

Disable mirror cache when initializing DebuggerScript.js We never look up mirror object by its id. To avoid possible memory leaks caused by mirrors stuck in the cache we disable mirror cache completely. This change depends on the ToggleMirrorCache added in V8 in https://code.google.com/p/v8/source/detail?r=21644 BUG=376534 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175642

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M Source/bindings/v8/DebuggerScript.js View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
yurys
6 years, 6 months ago (2014-06-06 06:05:35 UTC) #1
loislo
lgtm
6 years, 6 months ago (2014-06-06 06:06:44 UTC) #2
Yang
On 2014/06/06 06:06:44, loislo wrote: > lgtm Lgtm
6 years, 6 months ago (2014-06-06 06:07:50 UTC) #3
yurys
The CQ bit was checked by yurys@chromium.org
6 years, 6 months ago (2014-06-06 06:07:52 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yurys@chromium.org/317963003/1
6 years, 6 months ago (2014-06-06 06:08:03 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 07:16:15 UTC) #6
Message was sent while issue was closed.
Change committed as 175642

Powered by Google App Engine
This is Rietveld 408576698