Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 317953004: Set the "waiting" Service Worker of Service Worker providers (Closed)

Created:
6 years, 6 months ago by dominicc (has gone to gerrit)
Modified:
6 years, 6 months ago
Reviewers:
falken, Tom Sepez
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, kinuko+serviceworker, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, alecflett+watch_chromium.org
Visibility:
Public.

Description

Set the "waiting" Service Worker of Service Worker providers This provides the Service Worker for the implementation of navigator.serviceWorker.waiting in Blink. This will be covered by subsequent layout tests in Blink. BUG=379012 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276751

Patch Set 1 #

Patch Set 2 : First cut. #

Patch Set 3 : Initialize "waiting" for new clients. #

Total comments: 3

Patch Set 4 : Feedback and bring patch to head. #

Patch Set 5 : Bring patch to head. #

Patch Set 6 : Bring patch to head. #

Messages

Total messages: 12 (0 generated)
dominicc (has gone to gerrit)
PTAL Blink-side layout tests are in https://codereview.chromium.org/324893002/
6 years, 6 months ago (2014-06-10 05:06:07 UTC) #1
dominicc (has gone to gerrit)
+tsepez for content/common/service_worker/service_worker_messages.h
6 years, 6 months ago (2014-06-10 05:07:33 UTC) #2
Tom Sepez
Messages LGTM.
6 years, 6 months ago (2014-06-10 18:10:53 UTC) #3
falken
lgtm https://codereview.chromium.org/317953004/diff/40001/content/child/service_worker/service_worker_dispatcher.cc File content/child/service_worker/service_worker_dispatcher.cc (right): https://codereview.chromium.org/317953004/diff/40001/content/child/service_worker/service_worker_dispatcher.cc#newcode276 content/child/service_worker/service_worker_dispatcher.cc:276: // Populate the .current field with the new ...
6 years, 6 months ago (2014-06-10 20:34:28 UTC) #4
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-11 18:06:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/317953004/80001
6 years, 6 months ago (2014-06-11 18:10:08 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-11 22:28:57 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-11 22:32:32 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/builds/38092) win_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/builds/26241) win_chromium_x64_rel ...
6 years, 6 months ago (2014-06-11 22:32:33 UTC) #9
dominicc (has gone to gerrit)
The CQ bit was checked by dominicc@chromium.org
6 years, 6 months ago (2014-06-12 14:54:25 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dominicc@chromium.org/317953004/100001
6 years, 6 months ago (2014-06-12 14:56:33 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 18:27:40 UTC) #12
Message was sent while issue was closed.
Change committed as 276751

Powered by Google App Engine
This is Rietveld 408576698