Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Issue 317953002: :host-context selectors may affect insertion point descendants. (Closed)

Created:
6 years, 6 months ago by rune
Modified:
6 years, 6 months ago
Reviewers:
esprehn, dglazkov
CC:
blink-reviews, webcomponents-bugzilla_chromium.org, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, rwlbuis
Visibility:
Public.

Description

:host-context selectors may affect insertion point descendants. At insertion points, we schedule style recalcs for inserted nodes when we have a StyleRecalcChange at the insertion point's parent. One of the reasons is that :host-context selectors which affect inserted nodes may rely on matching nodes which are not ascendants of the inserted nodes in the dom used for selector matching. We did use a LocalStyleChange for the inserted nodes, but these selectors may affect any node in the inserted node's subtree. Hence, we start using SubtreeStyleChange instead. R=esprehn@chromium.org,dglazkov@chromium.org BUG=381020 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175636

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -1 line) Patch
A LayoutTests/fast/dom/shadow/host-context-class-change.html View 1 chunk +38 lines, -0 lines 0 comments Download
A LayoutTests/fast/dom/shadow/host-context-class-change-expected.txt View 1 chunk +11 lines, -0 lines 0 comments Download
M Source/core/dom/shadow/InsertionPoint.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
rune
PTAL
6 years, 6 months ago (2014-06-05 21:39:14 UTC) #1
esprehn
lgtm
6 years, 6 months ago (2014-06-05 23:30:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/317953002/1
6 years, 6 months ago (2014-06-05 23:31:18 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-06 01:21:31 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 01:21:55 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14600)
6 years, 6 months ago (2014-06-06 01:21:56 UTC) #6
esprehn
The CQ bit was checked by esprehn@chromium.org
6 years, 6 months ago (2014-06-06 01:24:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/317953002/1
6 years, 6 months ago (2014-06-06 01:24:56 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-06 01:26:24 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 01:26:48 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/14600)
6 years, 6 months ago (2014-06-06 01:26:49 UTC) #11
rune
The CQ bit was checked by rune@opera.com
6 years, 6 months ago (2014-06-06 05:28:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rune@opera.com/317953002/1
6 years, 6 months ago (2014-06-06 05:29:05 UTC) #13
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:30:05 UTC) #14
Message was sent while issue was closed.
Change committed as 175636

Powered by Google App Engine
This is Rietveld 408576698