tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py - Issue 317913003: Remove 'navigate' attribute from wait_until

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py

Issue 317913003: Remove 'navigate' attribute from wait_until (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py

diff --git a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py

index bd7680c073da3163389ecb311ae6b015ebe2c0e8..a9de7bc52615679556942a6f8b3d5c1a2f16c8fd 100644

--- a/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py

+++ b/tools/telemetry/telemetry/core/backends/chrome/inspector_backend.py

@@ -158,8 +158,8 @@ class InspectorBackend(inspector_websocket.InspectorWebsocket):

# Page public methods.

- def PerformActionAndWaitForNavigate(self, action_function, timeout):

- self._page.PerformActionAndWaitForNavigate(action_function, timeout)

+ def WaitForNavigate(self, timeout):

+ self._page.WaitForNavigate(timeout)

def Navigate(self, url, script_to_evaluate_on_commit, timeout):

self._page.Navigate(url, script_to_evaluate_on_commit, timeout)

« no previous file with comments | « tools/perf/page_sets/top_25.py ('k') | tools/telemetry/telemetry/core/backends/chrome/inspector_page.py » ('j') | no next file with comments »