Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 317903002: Change default generators on windows to include msvs-ninja rather than msvs (Closed)

Created:
6 years, 6 months ago by bsalomon
Modified:
6 years, 6 months ago
Reviewers:
epoger
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Change default generators on windows to include msvs-ninja rather than msvs BUG=skia:2439 TBR=epoger@google.com Committed: https://skia.googlesource.com/skia/+/a5c2824bd3a11364f3a4a8464538ab8a9cb15d0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M gyp_skia View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
bsalomon
The CQ bit was checked by bsalomon@google.com
6 years, 6 months ago (2014-06-05 14:00:17 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/bsalomon@google.com/317903002/1
6 years, 6 months ago (2014-06-05 14:01:16 UTC) #2
epoger
lgtm
6 years, 6 months ago (2014-06-05 14:03:03 UTC) #3
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:10:25 UTC) #4
Message was sent while issue was closed.
Change committed as a5c2824bd3a11364f3a4a8464538ab8a9cb15d0a

Powered by Google App Engine
This is Rietveld 408576698