Chromium Code Reviews
Help | Chromium Project | Sign in
(1)

Issues Search
Open Issues | Closed Issues | All Issues | Sign in with your Google Account to create issues and add comments

Issue 3179017: FBTF: Remove "obviously" unneeded standard C++ library #includes. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 9 months ago by viettrungluu
Modified:
3 years, 11 months ago
CC:
chromium-reviews, Raghu Simha, cbentzel+watch_chromium.org, nkostylev+cc_chromium.org, idana, ben+cc_chromium.org, John Grabowski, Erik does not do reviews, Paul Godavari, jam, ncarter, apatrick_chromium, stuartmorgan+watch_chromium.org, darin-cc_chromium.org, pam+watch_chromium.org, timsteele, Paweł Hajdan Jr., brettw-cc_chromium.org, native-client-reviews_googlegroups.com, davemoore+watch_chromium.org, dhollowa
Visibility:
Public.

Description

FBTF: Remove "obviously" unneeded standard C++ library #includes. BUG=none TEST=builds Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56171

Patch Set 1 #

Patch Set 2 : add missing #include in cros #

Patch Set 3 : fixed mac oopsie #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -279 lines) Patch
M chrome/browser/autocomplete/autocomplete_popup_view_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/autofill/autofill_cc_infobar_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/autofill/autofill_type.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/automation/ui_controls.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/automation/url_request_automation_job.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_drag_data.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/browsing_data_appcache_helper.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/cros/input_method_library.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/mock_mount_library.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/labs_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/dom_ui/proxy_handler.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/login/authenticator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/eula_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/login_utils.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/network_selection_view.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/chromeos/login/new_user_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/user_image_downloader.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/cellular_config_view.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/chromeos/options/language_config_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/options/language_config_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller_header.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/cocoa_test_helper.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/cocoa/content_exceptions_window_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/cocoa/content_setting_bubble_cocoa.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/cocoa/download_shelf_mac.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/cocoa/extensions/extension_install_prompt_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/cocoa/html_dialog_window_controller.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/cocoa/hung_renderer_controller.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/cocoa/location_bar/location_bar_view_mac.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/debugger/debugger_wrapper.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/dom_ui_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/history2_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/history_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/ntp_resource_cache.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/dom_ui/options_ui.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/dom_ui/slideshow_ui.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/download/download_file.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/download/download_file_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/download/download_shelf.h View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/download/download_util.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_data_deleter.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/extensions/extension_rlz_module.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/first_run/first_run.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/device_data_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_content_settings_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_exceptions_table_model.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/geolocation_permission_context.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/geolocation/wifi_data_provider_common_win.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/gtk/bookmark_bar_gtk.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/bookmark_editor_gtk.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/gtk/bookmark_tree_model.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/gtk/content_setting_bubble_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/custom_button.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/gtk_theme_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/content_exception_editor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/options/content_filter_page_gtk.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/options/fonts_page_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/gtk/options/managed_prefs_banner_gtk.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/gtk/options/simple_content_exceptions_window.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/history.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/history_publisher.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/history/in_memory_database.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/history/in_memory_history_backend.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/history/top_sites_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/icon_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/importer/firefox_profile_lock.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_area.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/in_process_webkit/dom_storage_permission_request.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/managed_prefs_banner_base.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/net/chrome_cookie_policy.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/gaia/token_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/predictor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/net/referrer.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/net/url_request_slow_http_job.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/balloon.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.h View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/notifications/notification_exceptions_table_model.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/native_backend_gnome_x.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/password_manager/password_store_default.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/policy/configuration_policy_pref_store.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/printing/cloud_print/cloud_print_proxy_service.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/printing/print_job_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/profile_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/profile_manager.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/renderer_host/render_process_host.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/renderer_host/render_widget_host_view_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/auth_watcher.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/engine/net/server_connection_manager.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/engine/syncer.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/syncer_thread.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/engine/update_applicator.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/glue/model_associator.h View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/glue/password_change_processor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/password_model_associator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/sync_backend_host.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/glue/typed_url_change_processor.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/sync/glue/typed_url_model_associator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/sessions/sync_session.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/sync/syncable/directory_backing_store.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/sync/syncable/syncable.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/util/user_settings.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/infobar_delegate.h View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu_gtk.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/tabs/pinned_tab_codec.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/translate/translate_prefs.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/bookmark_bubble_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/bookmark_editor_view.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/content_setting_bubble_views.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/create_application_shortcut_view.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/views/database_info_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/frame/browser_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/infobars/after_translate_infobar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/infobars/before_translate_infobar.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/keyword_editor_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/local_storage_info_view.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/views/local_storage_set_item_info_view.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/views/modal_dialog_delegate.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/views/tabs/tab_renderer_data.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/views/tabs/tab_strip_controller.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/visitedlink_master.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/webdata/web_data_service_test_util.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_plugin_lib.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_extent.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/gpu_messages.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/nacl_messages.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/common/utility_messages.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/common/zip.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/default_plugin/plugin_impl_gtk.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/default_plugin/plugin_impl_mac.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/default_plugin/plugin_impl_win.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/default_plugin/plugin_main.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/gpu/gpu_info_collector.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/installer/util/create_dir_work_item.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/installer/util/logging_installer.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/plugin/webplugin_delegate_stub.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/devtools_agent_filter.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/gpu_video_service_host.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/renderer/mock_render_thread.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/net/renderer_net_predictor.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/notification_provider.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/spellchecker/spellcheck_worditerator.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/renderer/user_script_slave.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/renderer/webplugin_delegate_pepper.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/automation/window_proxy.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/test/browser_with_test_window_test.h View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/test/sync/engine/proto_extension_validator.h View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/test/test_launcher/test_runner.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/tools/convert_dict/dic_reader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/worker/webworkerclient_proxy.h View 2 chunks +1 line, -3 lines 0 comments Download
Trybot results:  win 
Commit: CQ not working?

Messages

Total messages: 2 (0 generated)
viettrungluu
This is as big as it is boring (and vice versa).
4 years, 9 months ago (2010-08-14 22:44:48 UTC) #1
Aaron Boodman
4 years, 9 months ago (2010-08-15 18:57:27 UTC) #2 
lgtm
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld ec887be