Issue 3179011: [Mac] Removes artificial location padding logic to fix a bug with browser action transparency.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3179011: [Mac] Removes artificial location padding logic to fix a bug with browser action transparency. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by Andrew Bonventre (Bons)

Modified:
3 years, 10 months ago

Reviewers:
Mark Mentovai - out til August

CC:
chromium-reviews, John Grabowski, Erik does not do reviews, ben+cc_chromium.org, pam+watch_chromium.org, Aaron Boodman

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

[Mac] Removes artificial location padding logic to fix a bug with browser action transparency. BUG=51944 TEST=see bug. rightmost extension should not be transparent at all after resizing browser action container. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55960

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -6 lines)			Patch
	M	chrome/browser/cocoa/extensions/browser_actions_controller.mm	View		3 chunks	+2 lines, -6 lines	0 comments	Download

Trybot results: mac linux win

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

allays mtlg

Expand Messages | Collapse Messages