Set the first party for cookies url in RenderFrame

content/renderer/render_frame_impl.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/renderer/render_frame_impl.h"
 
 #include <map>
 #include <string>
 
 #include "base/auto_reset.h"
@@ skipping 2335 matching lines @@
 void RenderFrameImpl::willSendRequest(
     blink::WebLocalFrame* frame,
     unsigned identifier,
     blink::WebURLRequest& request,
     const blink::WebURLResponse& redirect_response) {
   DCHECK(!frame_ || frame_ == frame);
   // The request my be empty during tests.
   if (request.url().isEmpty())
     return;
 
+  // Set the first party for cookies url if it has not been set yet (new
+  // requests). For redirects, it is updated by WebURLLoaderImpl.
+  if (request.firstPartyForCookies().isEmpty()) {
+    if (request.targetType() == blink::WebURLRequest::TargetIsMainFrame)
+      request.setFirstPartyForCookies(request.url());
+    else
+      request.setFirstPartyForCookies(frame->top()->document().url());

[ppi, 2014/06/05 15:27:16]

Does it matter that we changed from ::firstPartyForCookies() to ::url() here?

[clamy, 2014/06/05 15:33:27]

firstPartyForCookies is not in the public blink API. What it does is get the url
of the topmost document. But AFAIK document() here already returns the topmost
document, so we should be fine.

[ppi, 2014/06/05 15:41:43]

I agree it's probably fine, but the function seems to be in the API, so we might
as well use:

https://code.google.com/p/chromium/codesearch#chromium/src/third_party/WebKit...

On 2014/06/05 15:33:27, clamy wrote:

[clamy, 2014/06/05 16:05:00]

My bad, missed it. In that case I agree that it is better to use it.

+  }
+
   WebFrame* top_frame = frame->top();
   if (!top_frame)
     top_frame = frame;
   WebDataSource* provisional_data_source = top_frame->provisionalDataSource();
   WebDataSource* top_data_source = top_frame->dataSource();
   WebDataSource* data_source =
       provisional_data_source ? provisional_data_source : top_data_source;
 
   PageTransition transition_type = PAGE_TRANSITION_LINK;
   DocumentState* document_state = DocumentState::FromDataSource(data_source);
@@ skipping 1177 matching lines @@
 
 RendererCdmManager* RenderFrameImpl::GetCdmManager() {
   if (!cdm_manager_)
     cdm_manager_ = new RendererCdmManager(this);
   return cdm_manager_;
 }
 
 #endif  // defined(OS_ANDROID)
 
 }  // namespace content