Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317843002: Turn on the new WebSocket implementation by default. (Closed)

Created:
6 years, 6 months ago by Adam Rice
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Turn on the new WebSocket implementation by default. BUG=381035 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175580

Patch Set 1 #

Patch Set 2 : Remove layout tests of old WebSocket implementation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2479 lines) Patch
M LayoutTests/TestExpectations View 1 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/FIXME-handshake-fail-by-null-subprotocol-selection-whitelist-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/alert-in-event-handler-expected.txt View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bad-handshake-crash-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bad-sub-protocol-control-chars-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bad-sub-protocol-empty-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bad-sub-protocol-non-ascii-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/binary-type-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/broken-utf8-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bufferedAmount-after-close-expected.txt View 1 1 chunk +0 lines, -72 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/bufferedAmount-after-close-in-busy-expected.txt View 1 1 chunk +0 lines, -73 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/client-close-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-before-handshake-response-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-before-open-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-code-and-reason-expected.txt View 1 1 chunk +0 lines, -87 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-event-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-expected.txt View 1 1 chunk +0 lines, -123 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-on-navigate-new-location-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-on-unload-and-force-gc-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-on-unload-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-on-unload-reference-in-parent-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-reason-too-long-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/close-unref-websocket-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/compressed-control-frame-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/connect-error-by-no-websocket-server-closeonclose-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/connect-error-by-no-websocket-server-closeonerror-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/connect-error-by-no-websocket-server-noclose-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/cookie-http-to-ws-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/cookie-ws-to-ws-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/cross-origin-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/deflate-frame-comp-bit-onoff-expected.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/deflate-frame-invalid-parameter-expected.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/deflate-frame-parameter-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/deflate-frame-set-bfinal-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/echo-with-no-extension-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/extensions-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/fragmented-binary-frames-expected.txt View 1 1 chunk +0 lines, -26 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/fragmented-control-frame-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/fragmented-frames-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/frame-lengths-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-challenge-randomness-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-error-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-extensions-header-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-maxlength-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-mismatch-protocol-header-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-more-accept-header-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-more-protocol-header-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-no-accept-header-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-no-connection-header-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-no-cr-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-no-upgrade-header-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-null-subprotocol-selection-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-prepended-null-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/handshake-fail-by-wrong-accept-header-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/httponly-cookie-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/interleaved-fragments-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/invalid-continuation-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/invalid-encode-length-expected.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/invalid-masked-frames-from-server-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/invalid-subprotocol-characters-expected.txt View 1 1 chunk +0 lines, -136 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/invalid-subprotocols-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/long-control-frame-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/long-invalid-header-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/multiple-connections-expected.txt View 1 1 chunk +0 lines, -3 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/multiple-subprotocols-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/no-crash-on-cookie-flood-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/no-subprotocol-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/nocache-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/null-character-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-comp-bit-onoff-expected.txt View 1 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-invalid-parameter-expected.txt View 1 1 chunk +0 lines, -28 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-parameter-expected.txt View 1 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-set-bfinal-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-unsolicited-negotiation-response-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/permessage-deflate-window-bits-expected.txt View 1 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/pong-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/receive-arraybuffer-expected.txt View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/receive-blob-expected.txt View 1 1 chunk +0 lines, -22 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/reload-crash-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/reserved-bits-expected.txt View 1 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/reserved-opcodes-expected.txt View 1 1 chunk +0 lines, -58 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-after-close-on-unload-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-arraybuffer-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-arraybufferview-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-blob-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-blob-onmessage-origin-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-empty-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-file-blob-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-file-blob-fail-expected.txt View 1 1 chunk +0 lines, -16 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-object-tostring-check-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-onmessage-origin-expected.txt View 1 1 chunk +0 lines, -15 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/send-throw-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/server-close-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/set-protocol-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/simple-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/simple-stress-expected.txt View 1 1 chunk +0 lines, -7 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/sub-protocol-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/too-long-payload-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/unicode-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/unmasked-frames-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/unpaired-surrogates-in-close-reason-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/unpaired-surrogates-in-message-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-attribute-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-no-trailing-slash-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-parsing-expected.txt View 1 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-with-credential-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-with-empty-query-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/url-with-query-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/useragent-in-openinghandshake-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/websocket-event-target-expected.txt View 1 1 chunk +0 lines, -18 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/websocket-pending-activity-expected.txt View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/close-code-and-reason-expected.txt View 1 1 chunk +0 lines, -74 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/close-expected.txt View 1 1 chunk +0 lines, -96 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/close-in-onmessage-crash-expected.txt View 1 1 chunk +0 lines, -11 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/close-in-shared-worker-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/close-in-worker-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/connect-error-by-no-websocket-server-closeonclose-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/connect-error-by-no-websocket-server-closeonerror-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/connect-error-by-no-websocket-server-noclose-expected.txt View 1 1 chunk +0 lines, -12 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/multiple-subprotocols-expected.txt View 1 1 chunk +0 lines, -19 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/no-onmessage-in-sync-op-expected.txt View 1 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/no-subprotocol-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/receive-arraybuffer-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/receive-blob-expected.txt View 1 1 chunk +0 lines, -23 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/send-arraybuffer-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/send-arraybufferview-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/send-blob-expected.txt View 1 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/shared-worker-simple-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/worker-handshake-challenge-randomness-expected.txt View 1 1 chunk +0 lines, -9 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/worker-reload-expected.txt View 1 1 chunk +0 lines, -10 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/workers/worker-simple-expected.txt View 1 1 chunk +0 lines, -14 lines 0 comments Download
D LayoutTests/virtual/stable/http/tests/websocket/zero-length-text-expected.txt View 1 1 chunk +0 lines, -17 lines 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 chunk +1 line, -1 line 0 comments Download
M Tools/Scripts/webkitpy/layout_tests/port/base.py View 1 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Adam Rice
6 years, 6 months ago (2014-06-05 07:10:55 UTC) #1
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-05 07:15:14 UTC) #2
yhirano
lgtm
6 years, 6 months ago (2014-06-05 07:18:28 UTC) #3
Adam Rice
+tkent for OWNERS.
6 years, 6 months ago (2014-06-05 07:21:18 UTC) #4
tkent
lgtm
6 years, 6 months ago (2014-06-05 07:23:32 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/317843002/1
6 years, 6 months ago (2014-06-05 07:24:08 UTC) #6
Adam Rice
Sorry, it turns out it's not that simple. We need to remove the layout test ...
6 years, 6 months ago (2014-06-05 08:00:37 UTC) #7
yhirano
I should have noticed... lgtm
6 years, 6 months ago (2014-06-05 09:00:43 UTC) #8
tyoshino (SeeGerritForStatus)
lgtm
6 years, 6 months ago (2014-06-05 09:07:09 UTC) #9
Adam Rice
The CQ bit was checked by ricea@chromium.org
6 years, 6 months ago (2014-06-05 09:31:43 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/317843002/20001
6 years, 6 months ago (2014-06-05 09:32:12 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-05 10:46:10 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 11:45:17 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10775)
6 years, 6 months ago (2014-06-05 11:45:17 UTC) #14
tkent
The CQ bit was checked by tkent@chromium.org
6 years, 6 months ago (2014-06-05 15:39:50 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ricea@chromium.org/317843002/20001
6 years, 6 months ago (2014-06-05 15:40:17 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 15:41:45 UTC) #17
Message was sent while issue was closed. 
Change committed as 175580

Powered by Google App Engine
This is Rietveld 408576698