Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4093)

Unified Diff: chrome/browser/chrome_content_browser_client.cc

Issue 317833006: [ICU] Avoid reading ICU data files in render process. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address reviewer's comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chrome_content_browser_client.cc
diff --git a/chrome/browser/chrome_content_browser_client.cc b/chrome/browser/chrome_content_browser_client.cc
index 0c8f73371a16eb251f6c77c5b9605fa8b99053f1..2d15b738ea43e220b68c81f29848bd1ef14c50f3 100644
--- a/chrome/browser/chrome_content_browser_client.cc
+++ b/chrome/browser/chrome_content_browser_client.cc
@@ -2641,6 +2641,18 @@ void ChromeContentBrowserClient::GetAdditionalMappedFilesForChildProcess(
}
}
+ base::FilePath app_data_path;
+ PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);
+ DCHECK(!app_data_path.empty());
+
+ flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
+ base::FilePath icudata_path =
+ app_data_path.AppendASCII("icudtl.dat");
+ base::File icudata_file(icudata_path, flags);
+ DCHECK(icudata_file.IsValid());
+ mappings->push_back(FileDescriptorInfo(kAndroidICUDataDescriptor,
+ FileDescriptor(icudata_file.Pass())));
+
#else
int crash_signal_fd = GetCrashSignalFD(command_line);
if (crash_signal_fd >= 0) {

Powered by Google App Engine
This is Rietveld 408576698