[ICU] Avoid reading ICU data files in render process.

chrome/browser/chrome_content_browser_client.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chrome_content_browser_client.h"
 
 #include <set>
 #include <utility>
 #include <vector>
 
@@ skipping 2624 matching lines @@
                child_process_id);
     if (file.IsValid()) {
       mappings->push_back(FileDescriptorInfo(kAndroidMinidumpDescriptor,
                                              FileDescriptor(file.Pass())));
     } else {
       LOG(ERROR) << "Failed to create file for minidump, crash reporting will "
                  "be disabled for this process.";
     }
   }
 
+  {

[jungshik at Google, 2014/06/05 23:30:58]

nit: I wonder why you enclosed this block with a pair of braces. I don't see any
lock (or am I missing something?) 

[Feng Qian, 2014/06/06 17:40:31]

I intended to scope variable names, but can remove it and rename variables.

On 2014/06/05 23:30:58, Jungshik Shin wrote:

+    base::FilePath app_data_path;
+    PathService::Get(base::DIR_ANDROID_APP_DATA, &app_data_path);
+    DCHECK(!app_data_path.empty());
+
+    int flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
+    base::FilePath icudlt_dat_path =
+        app_data_path.AppendASCII("icudtl.dat");

[jungshik at Google, 2014/06/05 23:30:57]

nit: |icudata_path| would be better, wouldn't it? 

[Feng Qian, 2014/06/06 17:40:31]

sure

On 2014/06/05 23:30:57, Jungshik Shin wrote:

+    base::File file(icudlt_dat_path, flags);
+    DCHECK(file.IsValid());
+    mappings->push_back(FileDescriptorInfo(kAndroidICUDataDescriptor,
+                                           FileDescriptor(file.Pass())));
+  }
 #else
   int crash_signal_fd = GetCrashSignalFD(command_line);
   if (crash_signal_fd >= 0) {
     mappings->push_back(FileDescriptorInfo(kCrashDumpSignal,
                                            FileDescriptor(crash_signal_fd,
                                                           false)));
   }
 #endif  // defined(OS_ANDROID)
 }
 #endif  // defined(OS_POSIX) && !defined(OS_MACOSX)
@@ skipping 102 matching lines @@
       switches::kDisableWebRtcEncryption,
     };
     to_command_line->CopySwitchesFrom(from_command_line,
                                       kWebRtcDevSwitchNames,
                                       arraysize(kWebRtcDevSwitchNames));
   }
 }
 #endif  // defined(ENABLE_WEBRTC)
 
 }  // namespace chrome