Hook PushMessagingMessageFilter up to GCMDriver

chrome/browser/services/gcm/push_messaging_service_impl.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/services/gcm/push_messaging_service_impl.h"
+
+#include <vector>
+
+#include "base/bind.h"
+#include "chrome/browser/services/gcm/gcm_profile_service.h"
+#include "components/gcm_driver/gcm_driver.h"
+
+namespace gcm {
+
+PushMessagingServiceImpl::PushMessagingServiceImpl(
+    GCMProfileService* gcm_profile_service)
+    : gcm_profile_service_(gcm_profile_service) {}
+
+PushMessagingServiceImpl::~PushMessagingServiceImpl() {}
+
+void PushMessagingServiceImpl::Register(
+    const std::string& app_id,
+    const std::string& sender_id,
+    const content::PushMessagingService::RegisterCallback& callback) {
+  // The GCMDriver could be NULL if GCMProfileService has been shut down.
+  if (!gcm_profile_service_->driver())
+    return;
+  std::vector<std::string> sender_ids(1, sender_id);
+  gcm_profile_service_->driver()->Register(
+      app_id,
+      sender_ids,
+      base::Bind(&PushMessagingServiceImpl::DidRegister,
+                 base::Unretained(this),

[fgorski, 2014/06/09 17:43:49]

This does not look safe, as you don't have any additional shutdown logic.
I think you should replace that with weak_ptr_factory.

[johnme, 2014/06/09 19:04:45]

I think it probably was safe, as this is a member variable of GCMProfileService
which owns GCMDriver, so it should always outlive GCMDriver (and the callback is
not persisted beyond the lifetime of GCMDriver). But I'm not 100% confident in
this, and a weak_ptr_factory does sound less brittle, so done.

+                 callback));
+}
+
+void PushMessagingServiceImpl::DidRegister(
+    const content::PushMessagingService::RegisterCallback& callback,
+    const std::string& registration_id,
+    GCMClient::Result result) {
+  GURL endpoint = GURL("https://android.googleapis.com/gcm/send");
+  bool error = (result != GCMClient::SUCCESS);
+  callback.Run(endpoint, registration_id, error);
+}
+
+}  // namespace gcm