Hook PushMessagingMessageFilter up to GCMDriver

chrome/browser/services/gcm/push_messaging_service_impl.cc

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/services/gcm/push_messaging_service_impl.h"
+
+#include <vector>
+
+#include "base/bind.h"
+#include "chrome/browser/services/gcm/gcm_profile_service.h"
+#include "components/gcm_driver/gcm_driver.h"
+
+namespace gcm {
+
+PushMessagingServiceImpl::PushMessagingServiceImpl(
+    GCMProfileService* gcm_profile_service)
+    : gcm_profile_service_(gcm_profile_service) {}
+
+PushMessagingServiceImpl::~PushMessagingServiceImpl() {}
+
+void PushMessagingServiceImpl::Register(
+    const std::string& app_id,
+    const std::string& sender_id,
+    const content::PushMessagingService::RegisterCallback& callback) {
+  if (!gcm_profile_service_->driver())

[jianli, 2014/06/06 17:32:21]

Please comment that GCMDriver could be NULL due to that the GCM service might be
shut down.

Or, you could avoid doing such check. You can let GCMProfileService own
PushMessagingServiceImpl via scoped_ptr. In GCMProfileService::Shutdown, you
also reset the scoped ptr.

[johnme, 2014/06/06 18:48:25]

I added the comment, since in the current approach, PushMessagingMessageFilters
keep a raw pointer to the PushMessagingService they are given, so I need the
lifetime of PushMessagingService to be greater than the lifetime of any
PushMessagingMessageFilters, which is tied to the lifetime of the corresponding
RenderProcessHosts. Open to other ways of handling the lifetimes though.

+    return;
+  std::vector<std::string> sender_ids(1, sender_id);
+  gcm_profile_service_->driver()->Register(
+      app_id,
+      sender_ids,
+      base::Bind(&PushMessagingServiceImpl::DidRegister,
+                 base::Unretained(this),
+                 callback));
+}
+
+void PushMessagingServiceImpl::DidRegister(
+    const content::PushMessagingService::RegisterCallback& callback,
+    const std::string& registration_id,
+    GCMClient::Result result) {
+  GURL endpoint = GURL("https://android.googleapis.com/gcm/send");
+  bool error = (result != GCMClient::SUCCESS);
+  callback.Run(endpoint, registration_id, error);
+}
+
+}  // namespace gcm