Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1093)

Unified Diff: slave/skia_slave_scripts/merge_into_android.py

Issue 317823006: Continue running if the upstream remote exists. (Closed) Base URL: https://skia.googlesource.com/buildbot.git@master
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: slave/skia_slave_scripts/merge_into_android.py
diff --git a/slave/skia_slave_scripts/merge_into_android.py b/slave/skia_slave_scripts/merge_into_android.py
index f072d86b8d5f599adf29d9c855883d10b92207ec..39607ee2c22edcc550bfffc1ecc751d9a6048b6b 100644
--- a/slave/skia_slave_scripts/merge_into_android.py
+++ b/slave/skia_slave_scripts/merge_into_android.py
@@ -56,8 +56,15 @@ class MergeIntoAndroid(BuildStep):
with misc.ChDir(EXTERNAL_SKIA):
# Check to see whether there is an upstream yet.
if not UPSTREAM_REMOTE_NAME in shell_utils.run([GIT, 'remote', 'show']):
- shell_utils.run([GIT, 'remote', 'add', UPSTREAM_REMOTE_NAME,
- SKIA_REPO_URL])
+ try:
+ shell_utils.run([GIT, 'remote', 'add', UPSTREAM_REMOTE_NAME,
+ SKIA_REPO_URL])
+ except shell_utils.CommandFailedException:
borenet 2014/06/05 18:40:44 It'd probably be a good idea to do something like
scroggo 2014/06/05 18:53:08 Done.
+ # Accept this error. If it failed for a reason other than the
+ # remote already existing, we'll see the error when we attempt to do
+ # a git fetch.
+ print ('%s was already added. Why did it not show in git remote'
+ ' show?' % UPSTREAM_REMOTE_NAME)
# Update the upstream remote.
shell_utils.run([GIT, 'fetch', UPSTREAM_REMOTE_NAME])
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698