Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Issue 317823006: Continue running if the upstream remote exists. (Closed)

Created:
6 years, 6 months ago by scroggo
Modified:
6 years, 6 months ago
Reviewers:
borenet
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/buildbot.git@master
Visibility:
Public.

Description

Continue running if the upstream remote exists. We already have code to check the git remotes to see if the upstream exists, but apparently it does not always succeed (see http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/684/steps/Merge/logs/stdio and http://108.170.220.27:10115/builders/Housekeeper-PerCommit-AndroidRoll/builds/662/steps/Merge/logs/stdio ). Committed: https://skia.googlesource.com/buildbot/+/172a50459340ecb4986a3b3892a8a02f43391503

Patch Set 1 #

Total comments: 2

Patch Set 2 : Respond to comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -2 lines) Patch
M slave/skia_slave_scripts/merge_into_android.py View 1 1 chunk +12 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
scroggo
6 years, 6 months ago (2014-06-05 18:36:11 UTC) #1
borenet
I wonder if this has something to do with the authentication we changed? https://codereview.chromium.org/317823006/diff/1/slave/skia_slave_scripts/merge_into_android.py File ...
6 years, 6 months ago (2014-06-05 18:40:44 UTC) #2
scroggo
https://codereview.chromium.org/317823006/diff/1/slave/skia_slave_scripts/merge_into_android.py File slave/skia_slave_scripts/merge_into_android.py (right): https://codereview.chromium.org/317823006/diff/1/slave/skia_slave_scripts/merge_into_android.py#newcode62 slave/skia_slave_scripts/merge_into_android.py:62: except shell_utils.CommandFailedException: On 2014/06/05 18:40:44, borenet wrote: > It'd ...
6 years, 6 months ago (2014-06-05 18:53:08 UTC) #3
borenet
LGTM
6 years, 6 months ago (2014-06-05 18:56:21 UTC) #4
scroggo
The CQ bit was checked by scroggo@google.com
6 years, 6 months ago (2014-06-05 18:58:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/scroggo@google.com/317823006/20001
6 years, 6 months ago (2014-06-05 18:59:09 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 18:59:20 UTC) #7
Message was sent while issue was closed.
Change committed as 172a50459340ecb4986a3b3892a8a02f43391503

Powered by Google App Engine
This is Rietveld 408576698