Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(896)

Issue 317823003: Fix submit_try (Closed)

Created:
6 years, 6 months ago by borenet
Modified:
6 years, 6 months ago
Reviewers:
epoger, tfarina
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 5

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+104 lines, -108 lines) Patch
M tools/buildbot_globals.py View 1 2 chunks +7 lines, -11 lines 0 comments Download
A tools/retrieve_from_googlesource.py View 1 1 chunk +37 lines, -0 lines 0 comments Download
M tools/submit_try View 1 7 chunks +60 lines, -97 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
borenet
Also removed svn-related stuff from submit_try.
6 years, 6 months ago (2014-06-05 13:47:38 UTC) #1
epoger
https://codereview.chromium.org/317823003/diff/1/tools/retrieve_from_googlesource.py File tools/retrieve_from_googlesource.py (right): https://codereview.chromium.org/317823003/diff/1/tools/retrieve_from_googlesource.py#newcode18 tools/retrieve_from_googlesource.py:18: def retrieve_from_googlesource(repo_url, filepath): maybe rename to be something different/shorter, ...
6 years, 6 months ago (2014-06-05 14:02:16 UTC) #2
borenet
Uploaded patch set 2. https://codereview.chromium.org/317823003/diff/1/tools/retrieve_from_googlesource.py File tools/retrieve_from_googlesource.py (right): https://codereview.chromium.org/317823003/diff/1/tools/retrieve_from_googlesource.py#newcode18 tools/retrieve_from_googlesource.py:18: def retrieve_from_googlesource(repo_url, filepath): On 2014/06/05 ...
6 years, 6 months ago (2014-06-05 14:09:49 UTC) #3
epoger
lgtm https://codereview.chromium.org/317823003/diff/1/tools/submit_try File tools/submit_try (right): https://codereview.chromium.org/317823003/diff/1/tools/submit_try#newcode232 tools/submit_try:232: Error('You must specify one or more builders using ...
6 years, 6 months ago (2014-06-05 14:12:44 UTC) #4
borenet
The CQ bit was checked by borenet@google.com
6 years, 6 months ago (2014-06-05 14:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/borenet@google.com/317823003/20001
6 years, 6 months ago (2014-06-05 14:13:50 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 14:32:19 UTC) #7
Message was sent while issue was closed.
Change committed as 2e81e51d1e932d34d602183130359514203efbbf

Powered by Google App Engine
This is Rietveld 408576698