Chromium Code Reviews| Index: ui/views/controls/native/native_view_host_wrapper.h |
| diff --git a/ui/views/controls/native/native_view_host_wrapper.h b/ui/views/controls/native/native_view_host_wrapper.h |
| index 306aa0148bbaa1d58ac1cefc8ed36be4c3cf737d..7897f7843c05cd7c99b3af42ce92dfad980cb1e1 100644 |
| --- a/ui/views/controls/native/native_view_host_wrapper.h |
| +++ b/ui/views/controls/native/native_view_host_wrapper.h |
| @@ -19,10 +19,10 @@ class VIEWS_EXPORT NativeViewHostWrapper { |
| public: |
| virtual ~NativeViewHostWrapper() {} |
| - // Called right before a gfx::NativeView is attached to the associated |
| - // NativeViewHost, allowing the wrapper to perform platform-specific |
| - // initialization. |
| - virtual void NativeViewWillAttach() = 0; |
| + // Called at the end of NativeViewHost::Attach, allowing the wrapper to |
| + // perform platform-specific operations that need to occur to complete |
| + // attaching the gfx::NativeView. |
| + virtual void AttachNativeView() = 0; |
| // Called before the attached gfx::NativeView is detached from the |
| // NativeViewHost, allowing the wrapper to perform platform-specific |
| @@ -38,13 +38,18 @@ class VIEWS_EXPORT NativeViewHostWrapper { |
| // rooted at a valid Widget. |
| virtual void RemovedFromWidget() = 0; |
| - // Installs a clip on the gfx::NativeView. |
| + // Installs a clip on the gfx::NativeView. These values are in the coordinate |
| + // space of the gfx::NativeView, so if this method is called from ShowWidget |
|
sky
2014/06/05 15:49:01
gfx::NativeView is overloaded here. I think you me
calamity
2014/06/06 08:13:45
Done.
|
| + // then the values need to be translated. |
| virtual void InstallClip(int x, int y, int w, int h) = 0; |
| // Whether or not a clip has been installed on the wrapped gfx::NativeView. |
| virtual bool HasInstalledClip() = 0; |
| - // Removes the clip installed on the gfx::NativeView by way of InstallClip. |
| + // Removes the clip installed on the gfx::NativeView by way of InstallClip. A |
| + // following call to ShowWidget should occur after calling this method to |
| + // position the gfx::NativeView correctly, since the clipping process may have |
| + // adjusted its position. |
| virtual void UninstallClip() = 0; |
| // Shows the gfx::NativeView at the specified position (relative to the parent |