Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317813003: Generate platform files under platform subdir. (Closed)

Created:
6 years, 6 months ago by c.shu
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Generate platform files under platform subdir. BUG=380054 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175589

Patch Set 1 #

Patch Set 2 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -20 lines) Patch
M Source/core/core.gyp View 2 chunks +3 lines, -2 lines 0 comments Download
M Source/core/core_generated.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/modules/modules_generated.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/blink_platform.gyp View 3 chunks +10 lines, -5 lines 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/platform/blink_platform_tests.gyp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/platform_generated.gyp View 4 chunks +9 lines, -8 lines 0 comments Download
A + Source/platform/platform_generated.gypi View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
c.shu
6 years, 6 months ago (2014-06-05 02:25:33 UTC) #1
Nils Barth (inactive)
LGTM, thanks! haraken, Eric: I assume this is fine?
6 years, 6 months ago (2014-06-05 02:30:17 UTC) #2
haraken
LGTM. Thanks for making these changes incrementally. It's very easy to review :)
6 years, 6 months ago (2014-06-05 02:52:51 UTC) #3
c.shu
On 2014/06/05 02:52:51, haraken wrote: > LGTM. > > Thanks for making these changes incrementally. ...
6 years, 6 months ago (2014-06-05 03:32:09 UTC) #4
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-05 03:32:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/317813003/1
6 years, 6 months ago (2014-06-05 03:32:46 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 04:42:15 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 04:44:27 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/6986)
6 years, 6 months ago (2014-06-05 04:44:27 UTC) #9
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-05 12:48:33 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/317813003/20001
6 years, 6 months ago (2014-06-05 12:49:16 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: blink_presubmit on tryserver.blink ...
6 years, 6 months ago (2014-06-05 13:50:02 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-05 13:51:42 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/7050)
6 years, 6 months ago (2014-06-05 13:51:43 UTC) #14
Julien - ping for review
platform OWNER: RSLGTM
6 years, 6 months ago (2014-06-05 18:39:20 UTC) #15
c.shu
The CQ bit was checked by c.shu@samsung.com
6 years, 6 months ago (2014-06-05 18:40:00 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/c.shu@samsung.com/317813003/20001
6 years, 6 months ago (2014-06-05 18:41:01 UTC) #17
commit-bot: I haz the power
6 years, 6 months ago (2014-06-05 20:07:57 UTC) #18
Message was sent while issue was closed. 
Change committed as 175589

Powered by Google App Engine
This is Rietveld 408576698