Don't assume output dir + "../.." == src/ in ui/gl/generate_bindings.py

Don't assume output dir + "../.." == src/ in ui/gl/generate_bindings.py

With gn, it'll probably be common for folks to generate their out directory
in places other than out/{Debug|Release}. This is technically possible (and
busted) in gyp as well. This avoids the relative path dependency from the
script and simplifies it some more by adding the src/ui/gl and src/gpu
directories in the build files (where they can be relativized properly)
instead of trying to do so in the script.

R=brettw@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275520

[brettw, 2014-06-05 02:37:35]

lgtm

[Ken Russell (switch to Gerrit), 2014-06-05 17:56:41]

LGTM if this has been tested, but a question.

https://codereview.chromium.org/317813002/diff/1/ui/gl/generate_bindings.py
File ui/gl/generate_bindings.py (right):

https://codereview.chromium.org/317813002/diff/1/ui/gl/generate_bindings.py#n...
ui/gl/generate_bindings.py:1969: result =
os.path.relpath(os.path.join(os.getcwd(), result), os.getcwd())
Why is using cwd correct? What does rebase_path in the .gn file produce? A path
relative to cwd?

[jamesr, 2014-06-05 18:10:39]

On 2014/06/05 17:56:41, Ken Russell wrote:
> LGTM if this has been tested, but a question.
> 
> https://codereview.chromium.org/317813002/diff/1/ui/gl/generate_bindings.py
> File ui/gl/generate_bindings.py (right):
> 
>
https://codereview.chromium.org/317813002/diff/1/ui/gl/generate_bindings.py#n...
> ui/gl/generate_bindings.py:1969: result =
> os.path.relpath(os.path.join(os.getcwd(), result), os.getcwd())
> Why is using cwd correct? What does rebase_path in the .gn file produce? A
path
> relative to cwd?

ninja cd's into the directory specified by -C when running, so getcwd() will be
out/{Debug|Release|Debug_x64...}/ in a gyp build or root_build_dir in a GN
build.  The header paths are explicitly rebased against root_build_dir in the GN
build, so they'll be relative to cwd.

[jamesr, 2014-06-05 18:10:41]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-06-05 18:11:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/317813002/1

[commit-bot: I haz the power, 2014-06-05 22:11:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)
  linux_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)

[commit-bot: I haz the power, 2014-06-05 22:18:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-05 22:18:48]

Try jobs failed on following builders:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[jamesr, 2014-06-06 20:45:37]

The CQ bit was checked by jamesr@chromium.org

[commit-bot: I haz the power, 2014-06-06 20:46:17]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jamesr@chromium.org/317813002/1

[commit-bot: I haz the power, 2014-06-06 20:48:10]

Change committed as 275520