Add function to document_loader to get PDF as pp::FileRef

Add function to document_loader to get PDF as pp::FileRef

BUG=224520

[raymes, 2014-06-05 06:25:56]

I drafted up this CL to save the PDF to a file ref, but I'm wary of implementing
the IPC part until we know how we will plug into the download manager.

[Lei Zhang, 2014-06-05 07:23:53]

Mostly good. I assume this is going to stay here until we figure out all the
pieces?

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc
File pdf/document_loader.cc (right):

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:132: pp::CompletionCallbackWithOutput<pp::FileRef>
callback) {
nit: indentation

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:133: if (!IsDocumentComplete() ||
chunk_stream_.data().size() == 0) {
nit: size() == 0  -> empty()

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:141: "pdf",
Probably ok for now, but shouldn't the caller normally specify the filename?

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:142: reinterpret_cast<const
char*>(&chunk_stream_.data()[0]),
Maybe just have FileWriter hold a const std::string& to the data, rather than a
separate pointer + size?

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.cc
File pdf/file_writer.cc (right):

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.cc#newcode58
pdf/file_writer.cc:58: callback_->Run(result);
Do you need to call io_.Close() here? Same with the error handling in
FileWriter::OnFlushComplete().

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.h
File pdf/file_writer.h (right):

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.h#newcode1
pdf/file_writer.h:1: // Copyright (c) 2014 The Chromium Authors. All rights
reserved.
nit: no (c) in new code.

[raymes, 2014-06-06 01:57:14]

Thanks. Yeah I'll just leave it here until the download manager part is done,
then I'll be happy to hook it up.

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc
File pdf/document_loader.cc (right):

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:132: pp::CompletionCallbackWithOutput<pp::FileRef>
callback) {
On 2014/06/05 07:23:54, Lei Zhang wrote:
> nit: indentation

Done.

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:133: if (!IsDocumentComplete() ||
chunk_stream_.data().size() == 0) {
On 2014/06/05 07:23:54, Lei Zhang wrote:
> nit: size() == 0  -> empty()

Done.

https://codereview.chromium.org/317803005/diff/1/pdf/document_loader.cc#newco...
pdf/document_loader.cc:141: "pdf",
This will just be a temporary filename. The download manager should prompt the
user for the file name and then copy/move this file to the given location.

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.cc
File pdf/file_writer.cc (right):

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.cc#newcode58
pdf/file_writer.cc:58: callback_->Run(result);
On 2014/06/05 07:23:54, Lei Zhang wrote:
> Do you need to call io_.Close() here? Same with the error handling in
> FileWriter::OnFlushComplete().

Done.

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.h
File pdf/file_writer.h (right):

https://codereview.chromium.org/317803005/diff/1/pdf/file_writer.h#newcode1
pdf/file_writer.h:1: // Copyright (c) 2014 The Chromium Authors. All rights
reserved.
On 2014/06/05 07:23:54, Lei Zhang wrote:
> nit: no (c) in new code.

Done.