Issue 3178001: Delete callbacks after use in canned browsing data helpers.

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 3178001: Delete callbacks after use in canned browsing data helpers. (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
4 years, 9 months ago by jochen

Modified:
4 years ago

Reviewers:
Nico

CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org

Visibility:
Public.

Description

Delete callbacks after use in canned browsing data helpers. BUG=49750 TEST=Canned*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55688

Patch Set 1 #

Created: 4 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+26 lines, -42 lines)			Patch
M	chrome/browser/browsing_data_appcache_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_appcache_helper_unittest.cc	View	4 chunks	+7 lines, -4 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_database_helper_unittest.cc	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/browsing_data_local_storage_helper_unittest.cc	View	4 chunks	+8 lines, -9 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	1 chunk	+0 lines, -10 lines	0 comments	Download

Trybot results: win linux mac_valgrind linux_valgrind mac

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nico

4 years, 9 months ago (2010-08-11 08:06:00 UTC) #2

lg

crazy, i thought callbacks delete themselves after being run. maybe the google3
ones do.

Expand Messages | Collapse Messages