Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 3178001: Delete callbacks after use in canned browsing data helpers. (Closed)

Created:
10 years, 4 months ago by jochen (gone - plz use gerrit)
Modified:
9 years, 7 months ago
Reviewers:
Nico
CC:
chromium-reviews, Alexander Potapenko, ben+cc_chromium.org, Timur Iskhodzhanov, pam+watch_chromium.org, Paweł Hajdan Jr., stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Delete callbacks after use in canned browsing data helpers. BUG=49750 TEST=Canned*.* Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=55688

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -42 lines) Patch
M chrome/browser/browsing_data_appcache_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data_appcache_helper_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M chrome/browser/browsing_data_database_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data_database_helper_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/browsing_data_local_storage_helper_unittest.cc View 4 chunks +8 lines, -9 lines 0 comments Download
M tools/valgrind/memcheck/suppressions.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M tools/valgrind/memcheck/suppressions_mac.txt View 1 chunk +0 lines, -10 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jochen (gone - plz use gerrit)
please review.
10 years, 4 months ago (2010-08-11 07:59:48 UTC) #1
Nico
10 years, 4 months ago (2010-08-11 08:06:00 UTC) #2
lg

crazy, i thought callbacks delete themselves after being run. maybe the google3
ones do.

Powered by Google App Engine
This is Rietveld 408576698