Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 317783012: Pass in the time of the user's last activity timestamp with the NET_ACTIVE_WINDOW event (Closed)

Created:
6 years, 6 months ago by pkotwicz
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, tfarina, ben+views_chromium.org, tdanderson+views_chromium.org
Visibility:
Public.

Description

Pass in the time of the user's last activity timestamp with the _NET_ACTIVE_WINDOW event. _NET_ACTIVE_WINDOW events with a CurrentTime timestamp are ignored by Unity. BUG=365450, 355667 TEST=Manual, see bug Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275372

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -10 lines) Patch
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc View 3 chunks +29 lines, -9 lines 1 comment Download
M ui/views/widget/desktop_aura/x11_desktop_handler.h View 2 chunks +13 lines, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/x11_desktop_handler.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
pkotwicz
Elliot, can you please take a look?
6 years, 6 months ago (2014-06-05 20:10:13 UTC) #1
Elliot Glaysher
https://codereview.chromium.org/317783012/diff/50001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc File ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc (right): https://codereview.chromium.org/317783012/diff/50001/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc#newcode1203 ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc:1203: type == ui::ET_TOUCH_PRESSED) { I'm pretty sure you want ...
6 years, 6 months ago (2014-06-05 20:46:33 UTC) #2
pkotwicz
It looks like the GTK implementation updates the user time: - when a key is ...
6 years, 6 months ago (2014-06-05 21:34:32 UTC) #3
Elliot Glaysher
On 2014/06/05 21:34:32, pkotwicz wrote: > It looks like the GTK implementation updates the user ...
6 years, 6 months ago (2014-06-05 21:37:32 UTC) #4
pkotwicz
I do not understand. The CL handles XInput2 ET_KEY_PRESSED and ET_MOUSE_PRESSED events
6 years, 6 months ago (2014-06-05 22:13:23 UTC) #5
Elliot Glaysher
On 2014/06/05 22:13:23, pkotwicz wrote: > I do not understand. The CL handles XInput2 ET_KEY_PRESSED ...
6 years, 6 months ago (2014-06-05 22:18:58 UTC) #6
pkotwicz
The CQ bit was checked by pkotwicz@chromium.org
6 years, 6 months ago (2014-06-05 22:22:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/317783012/50001
6 years, 6 months ago (2014-06-05 22:24:32 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:17:19 UTC) #9
Message was sent while issue was closed.
Change committed as 275372

Powered by Google App Engine
This is Rietveld 408576698