chrome.hid: enrich model with report IDs

device/hid/hid_usage_and_page.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef DEVICE_HID_HID_USAGE_AND_PAGE_H_
 #define DEVICE_HID_HID_USAGE_AND_PAGE_H_
 
 #include "base/basictypes.h"
 
 namespace device {
@@ skipping 108 matching lines @@
     kGenericDesktopSystemDisplaySwap = 0xb6,
   };
 
   HidUsageAndPage(uint16_t usage, Page usage_page)
       : usage(usage), usage_page(usage_page) {}
   ~HidUsageAndPage() {}
 
   uint16_t usage;
   Page usage_page;
 
-  bool operator==(const HidUsageAndPage& other) const;
+  // Such usages can raise security or privacy concerns.

[Ken Rockot(use gerrit already), 2014/06/06 20:04:44]

Function docs should be third-person declarative statements e.g.:

// Indicates whether this usage is protected by Chrome.

[jracle (use Gerrit), 2014/06/07 12:56:22]

Got it.

On 2014/06/06 20:04:44, Ken Rockot wrote:

+  bool IsSensitive() const;

[Ken Rockot(use gerrit already), 2014/06/06 20:04:44]

How about IsProtected()

[jracle (use Gerrit), 2014/06/07 12:56:22]

I'll rename with you proposal. Understand mine is not satisfactory.

But maybe we can find another one with a name which would reflect what those
usages are (represent) inherently, as OOP tells us, not what their usage (pardon
the pun) is intended to become.

To be clearer, mouse reports lead to privacy concerns, but are not by themselves
'protected' (at least not on all OSes).

You see my point?

On 2014/06/06 20:04:44, Ken Rockot wrote:

 };
 
 }  // namespace device
 
 #endif  // DEVICE_HID_HID_USAGE_AND_PAGE_H_