Do not assign revision when checking the commit existence.

Do not assign revision when checking the commit existence.

'git rev-parse <revision> will return same revision result with
newline appended if revision exists. The newline will cause the
following checkout command will fail, so remove the assignment.

BUG=
R=agable@chromium.org, rogerta@chromium.org

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=277615

[agable, 2014-06-11 21:16:28]

On 2014/06/06 07:20:35, haltonhuo wrote:

Much better to .strip() the output than to remove the assignment. The assignment
is there to normalize all refs ("refs/remotes/origin/master",
"refs/heads/thingy", "foo-bar-baz") to 40-character hash form.

[haltonhuo, 2014-06-13 03:45:23]

On 2014/06/11 21:16:28, agable wrote:
> On 2014/06/06 07:20:35, haltonhuo wrote:
> 
> Much better to .strip() the output than to remove the assignment. The
assignment
> is there to normalize all refs ("refs/remotes/origin/master",
> "refs/heads/thingy", "foo-bar-baz") to 40-character hash form.

Thanks for review, patch set2 is changed with strip()

[Roger Tawa OOO till Jul 10th, 2014-06-13 14:46:11]

Hi Halton,

Sorry for late response.  Your change looks fine to me, but I think you should
have someone on the build team take a look.

[haltonhuo, 2014-06-16 03:53:22]

On 2014/06/13 14:46:11, Roger Tawa wrote:
> Hi Halton,
> 
> Sorry for late response.  Your change looks fine to me, but I think you should
> have someone on the build team take a look.

Roger, thanks for reviewing. Any names from build team?

[Roger Tawa OOO till Jul 10th, 2014-06-16 14:46:00]

On 2014/06/16 03:53:22, haltonhuo wrote:
> On 2014/06/13 14:46:11, Roger Tawa wrote:
> > Hi Halton,
> > 
> > Sorry for late response.  Your change looks fine to me, but I think you
should
> > have someone on the build team take a look.
> 
> Roger, thanks for reviewing. Any names from build team?

Hi Halton,

Anyone in the OWNERS file would do.

[agable, 2014-06-16 21:32:45]

On 2014/06/16 at 14:46:00, rogerta wrote:
> On 2014/06/16 03:53:22, haltonhuo wrote:
> > On 2014/06/13 14:46:11, Roger Tawa wrote:
> > > Hi Halton,
> > > 
> > > Sorry for late response.  Your change looks fine to me, but I think you
should
> > > have someone on the build team take a look.
> > 
> > Roger, thanks for reviewing. Any names from build team?
> 
> Hi Halton,
> 
> Anyone in the OWNERS file would do.

OWNERS LGTM from me.

[haltonhuo, 2014-06-17 01:48:03]

The CQ bit was checked by halton.huo@intel.com

[commit-bot: I haz the power, 2014-06-17 01:48:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/halton.huo@intel.com/317783008/20001

[commit-bot: I haz the power, 2014-06-17 01:50:39]

Change committed as 277615