Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 317783007: Handle tap gestures in desktop media picker's source list (Closed)

Created:
6 years, 6 months ago by tbarzic
Modified:
6 years, 6 months ago
Reviewers:
Sergey Ulanov, sky
CC:
chromium-reviews, tfarina
Visibility:
Public.

Description

Handle tap gestures in desktop media picker's source list Focus a media source when it's view is tapped. Select it on double-tap. BUG=380490 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275333

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -0 lines) Patch
M chrome/browser/ui/views/desktop_media_picker_views.cc View 1 3 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tbarzic
(sky for owner approval)
6 years, 6 months ago (2014-06-04 23:52:30 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-05 14:45:17 UTC) #2
Sergey Ulanov
lgtm
6 years, 6 months ago (2014-06-05 20:05:32 UTC) #3
tbarzic
The CQ bit was checked by tbarzic@chromium.org
6 years, 6 months ago (2014-06-05 20:06:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tbarzic@chromium.org/317783007/20001
6 years, 6 months ago (2014-06-05 20:07:19 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 00:12:41 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 05:10:38 UTC) #7
Message was sent while issue was closed.
Change committed as 275333

Powered by Google App Engine
This is Rietveld 408576698