Fix Win64 build of Dart VM.

runtime/bin/socket_win.cc

Index: runtime/bin/socket_win.cc
diff --git a/runtime/bin/socket_win.cc b/runtime/bin/socket_win.cc
index 5ec7f1fa7c5c2c5052ef59e2613c3717914534d8..7835d7b68ca16284971079e41efb69804931fc74 100644
--- a/runtime/bin/socket_win.cc
+++ b/runtime/bin/socket_win.cc
@@ -70,7 +70,7 @@ intptr_t Socket::Available(intptr_t fd) {
 }
 
 
-intptr_t Socket::Read(intptr_t fd, void* buffer, intptr_t num_bytes) {
+int Socket::Read(intptr_t fd, void* buffer, intptr_t num_bytes) {

[srdjan, 2014/06/05 17:00:46]

Why is this necessary?

[siva, 2014/06/05 17:21:18]

Not sure I understand the divergence, num_bytes is an intptr_t and Read returns
the number of bytes read which in most cases would be num_bytes unless there is
a short read, why change the return value type then?

[Ivan Posva, 2014/06/05 17:42:11]

I see why this is necessary, but the real problem is that Socket::Read is
defined to return an int and not an intptr_t, which would be the correct thing
to do.

Should be fixed with this CL: https://codereview.chromium.org/312343002/

[Vyacheslav Egorov (Google), 2014/06/05 18:05:55]

Thanks. I will revert my changes to this file.

Handle::Read is defined to returned int still though even after your CL.

[Ivan Posva, 2014/06/05 18:13:38]

Please file a bug against IO and check with Anders what the lower layers of
Windows provide on 64-bit machines.

   Handle* handle = reinterpret_cast<Handle*>(fd);
   return handle->Read(buffer, num_bytes);
 }
@@ -84,7 +84,7 @@ int Socket::RecvFrom(intptr_t fd, void* buffer, intptr_t num_bytes,
 }
 
 
-intptr_t Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {
+int Socket::Write(intptr_t fd, const void* buffer, intptr_t num_bytes) {
   Handle* handle = reinterpret_cast<Handle*>(fd);
   return handle->Write(buffer, num_bytes);
 }