Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317733006: pkg/matcher: reapply 36881,36896 working around Issue 19173 (Closed)

Created:
6 years, 6 months ago by kevmoo
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

pkg/matcher: reapply 36881,36896 working around Issue 19173 Reverted in 36912 R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=37036

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1523 lines, -1698 lines) Patch
A pkg/matcher/CHANGELOG.md View 1 chunk +21 lines, -0 lines 0 comments Download
A pkg/matcher/README.md View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/matcher/lib/matcher.dart View 1 chunk +10 lines, -24 lines 0 comments Download
M pkg/matcher/lib/mirror_matchers.dart View 1 chunk +5 lines, -9 lines 0 comments Download
M pkg/matcher/lib/src/core_matchers.dart View 16 chunks +129 lines, -294 lines 0 comments Download
M pkg/matcher/lib/src/description.dart View 3 chunks +21 lines, -35 lines 0 comments Download
A pkg/matcher/lib/src/error_matchers.dart View 1 1 chunk +173 lines, -0 lines 0 comments Download
M pkg/matcher/lib/src/expect.dart View 6 chunks +45 lines, -54 lines 0 comments Download
M pkg/matcher/lib/src/future_matchers.dart View 1 chunk +24 lines, -22 lines 0 comments Download
M pkg/matcher/lib/src/interfaces.dart View 1 chunk +45 lines, -62 lines 0 comments Download
M pkg/matcher/lib/src/iterable_matchers.dart View 9 chunks +38 lines, -46 lines 0 comments Download
M pkg/matcher/lib/src/map_matchers.dart View 2 chunks +7 lines, -8 lines 0 comments Download
M pkg/matcher/lib/src/numeric_matchers.dart View 6 chunks +49 lines, -72 lines 0 comments Download
M pkg/matcher/lib/src/operator_matchers.dart View 5 chunks +68 lines, -102 lines 0 comments Download
M pkg/matcher/lib/src/pretty_print.dart View 5 chunks +52 lines, -16 lines 0 comments Download
M pkg/matcher/lib/src/string_matchers.dart View 8 chunks +59 lines, -72 lines 0 comments Download
D pkg/matcher/lib/src/utils.dart View 1 chunk +0 lines, -69 lines 0 comments Download
M pkg/matcher/pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
A pkg/matcher/test/core_matchers_test.dart View 1 chunk +211 lines, -0 lines 0 comments Download
A pkg/matcher/test/deprecated_matchers_test.dart View 1 chunk +33 lines, -0 lines 0 comments Download
A pkg/matcher/test/future_matchers_test.dart View 1 chunk +76 lines, -0 lines 0 comments Download
A pkg/matcher/test/iterable_matchers_test.dart View 1 chunk +166 lines, -0 lines 0 comments Download
D pkg/matcher/test/matchers_test.dart View 1 chunk +0 lines, -803 lines 0 comments Download
A pkg/matcher/test/numeric_matchers_test.dart View 1 chunk +152 lines, -0 lines 0 comments Download
A pkg/matcher/test/operator_matchers_test.dart View 1 chunk +28 lines, -0 lines 0 comments Download
A pkg/matcher/test/string_matchers_test.dart View 1 chunk +94 lines, -0 lines 0 comments Download
M pkg/matcher/test/test_common.dart View 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/pkg.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
kevmoo
6 years, 6 months ago (2014-06-05 16:37:43 UTC) #1
Siggi Cherem (dart-lang)
lgtm https://codereview.chromium.org/317733006/diff/1/pkg/matcher/lib/src/error_matchers.dart File pkg/matcher/lib/src/error_matchers.dart (right): https://codereview.chromium.org/317733006/diff/1/pkg/matcher/lib/src/error_matchers.dart#newcode13 pkg/matcher/lib/src/error_matchers.dart:13: // TODO(kevmoo): re-deprecate once 19173 is resolves resolves ...
6 years, 6 months ago (2014-06-05 16:55:20 UTC) #2
kevmoo
https://codereview.chromium.org/317733006/diff/1/pkg/matcher/lib/src/error_matchers.dart File pkg/matcher/lib/src/error_matchers.dart (right): https://codereview.chromium.org/317733006/diff/1/pkg/matcher/lib/src/error_matchers.dart#newcode13 pkg/matcher/lib/src/error_matchers.dart:13: // TODO(kevmoo): re-deprecate once 19173 is resolves On 2014/06/05 ...
6 years, 6 months ago (2014-06-05 17:10:24 UTC) #3
kevmoo
6 years, 6 months ago (2014-06-05 17:11:18 UTC) #4
Message was sent while issue was closed. 
Committed patchset #2 manually as r37036 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698