Issue 317733003: Add utils gypi file

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 317733003: Add utils gypi file (Closed)

Created:
6 years, 6 months ago by egdaniel

Modified:
6 years, 6 months ago

Reviewers:
bsalomon, robertphillips

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

Add utils gypi file BUG=skia: Committed: https://skia.googlesource.com/skia/+/ea902d915083ddb57ea10b030f914e585aae79bc

Patch Set 3 : Fix indentation nit #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+125 lines, -110 lines)			Patch
	M	gyp/utils.gyp	View		2 chunks	+4 lines, -110 lines	0 comments	Download
	A	gyp/utils.gypi	View	1 2	1 chunk	+121 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

robertphillips

lgtm + indentation nit https://codereview.chromium.org/317733003/diff/20001/gyp/utils.gypi File gyp/utils.gypi (right): https://codereview.chromium.org/317733003/diff/20001/gyp/utils.gypi#newcode7 gyp/utils.gypi:7: # indent seems a bit ...

6 years, 6 months ago (2014-06-04 17:20:30 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/317733003/30003

6 years, 6 months ago (2014-06-04 17:26:15 UTC) #4

commit-bot: I haz the power

6 years, 6 months ago (2014-06-04 17:37:19 UTC) #5

Message was sent while issue was closed.

Change committed as ea902d915083ddb57ea10b030f914e585aae79bc

Expand Messages | Collapse Messages

Issue 317733003: Add utils gypi file (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Fix indentation nit #

Messages