Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 31773002: cryptohome: Convet all *Stub classes into Fake* classes (Closed)

Created:
7 years, 2 months ago by satorux1
Modified:
7 years, 2 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Visibility:
Public.

Description

cryptohome: Convet all *Stub classes into Fake* classes ShillProfileClientStub is renamed to FakeShillProfileClient. ShillServiceClientStub is renamed to FakeShillServiceClient ShillManagerClientStub is renamed to FakeShillManagerClient, and the original FakeShillManagerClient is removed. BUG=309506 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=229770

Patch Set 1 : #

Total comments: 4

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+749 lines, -1911 lines) Patch
M chromeos/chromeos.gyp View 3 chunks +6 lines, -8 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.h View 3 chunks +75 lines, -18 lines 0 comments Download
M chromeos/dbus/fake_shill_manager_client.cc View 1 chunk +580 lines, -48 lines 0 comments Download
A + chromeos/dbus/fake_shill_profile_client.h View 2 chunks +11 lines, -9 lines 0 comments Download
A + chromeos/dbus/fake_shill_profile_client.cc View 10 chunks +17 lines, -17 lines 0 comments Download
A + chromeos/dbus/fake_shill_service_client.h View 3 chunks +13 lines, -12 lines 0 comments Download
A + chromeos/dbus/fake_shill_service_client.cc View 26 chunks +40 lines, -40 lines 0 comments Download
M chromeos/dbus/shill_manager_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/dbus/shill_manager_client_stub.h View 1 chunk +0 lines, -132 lines 0 comments Download
D chromeos/dbus/shill_manager_client_stub.cc View 1 chunk +0 lines, -636 lines 0 comments Download
M chromeos/dbus/shill_profile_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/dbus/shill_profile_client_stub.h View 1 chunk +0 lines, -72 lines 0 comments Download
D chromeos/dbus/shill_profile_client_stub.cc View 1 chunk +0 lines, -208 lines 0 comments Download
M chromeos/dbus/shill_service_client.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D chromeos/dbus/shill_service_client_stub.h View 1 chunk +0 lines, -134 lines 0 comments Download
D chromeos/dbus/shill_service_client_stub.cc View 1 chunk +0 lines, -569 lines 0 comments Download
M chromeos/dbus/shill_stub_helper.h View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/dbus/shill_stub_helper.cc View 1 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
satorux1
https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/fake_shill_manager_client.cc File chromeos/dbus/fake_shill_manager_client.cc (right): https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/fake_shill_manager_client.cc#newcode1 chromeos/dbus/fake_shill_manager_client.cc:1: // Copyright 2013 The Chromium Authors. All rights reserved. ...
7 years, 2 months ago (2013-10-21 06:13:33 UTC) #1
satorux1
7 years, 2 months ago (2013-10-21 06:13:42 UTC) #2
hashimoto
lgtm presuming nothing is wrong with FakeShillManagerClient https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/shill_stub_helper.cc File chromeos/dbus/shill_stub_helper.cc (right): https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/shill_stub_helper.cc#newcode11 chromeos/dbus/shill_stub_helper.cc:11: #include "chromeos/dbus/fake_shill_profile_client.h" ...
7 years, 2 months ago (2013-10-21 06:39:25 UTC) #3
satorux1
https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/shill_stub_helper.cc File chromeos/dbus/shill_stub_helper.cc (right): https://codereview.chromium.org/31773002/diff/40001/chromeos/dbus/shill_stub_helper.cc#newcode11 chromeos/dbus/shill_stub_helper.cc:11: #include "chromeos/dbus/fake_shill_profile_client.h" On 2013/10/21 06:39:26, hashimoto wrote: > Is ...
7 years, 2 months ago (2013-10-21 06:44:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/satorux@chromium.org/31773002/160001
7 years, 2 months ago (2013-10-21 07:12:27 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-21 10:00:19 UTC) #6
Message was sent while issue was closed. 
Change committed as 229770

Powered by Google App Engine
This is Rietveld 408576698