Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(123)

Side by Side Diff: ui/app_list/views/app_list_view_unittest.cc

Issue 317723005: Refactor app list ContentsView to use page indices, not show states. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fixed AppListViewTest. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ui/app_list/views/app_list_view.h" 5 #include "ui/app_list/views/app_list_view.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/run_loop.h" 8 #include "base/run_loop.h"
9 #include "base/strings/string_util.h" 9 #include "base/strings/string_util.h"
10 #include "testing/gtest/include/gtest/gtest.h" 10 #include "testing/gtest/include/gtest/gtest.h"
(...skipping 265 matching lines...) Expand 10 before | Expand all | Expand 10 after
276 276
277 AppListMainView* main_view = view_->app_list_main_view(); 277 AppListMainView* main_view = view_->app_list_main_view();
278 StartPageView* start_page_view = 278 StartPageView* start_page_view =
279 main_view->contents_view()->start_page_view(); 279 main_view->contents_view()->start_page_view();
280 // Checks on the main view. 280 // Checks on the main view.
281 EXPECT_NO_FATAL_FAILURE(CheckView(main_view)); 281 EXPECT_NO_FATAL_FAILURE(CheckView(main_view));
282 EXPECT_NO_FATAL_FAILURE(CheckView(main_view->contents_view())); 282 EXPECT_NO_FATAL_FAILURE(CheckView(main_view->contents_view()));
283 if (test_type_ == EXPERIMENTAL) { 283 if (test_type_ == EXPERIMENTAL) {
284 EXPECT_NO_FATAL_FAILURE(CheckView(start_page_view)); 284 EXPECT_NO_FATAL_FAILURE(CheckView(start_page_view));
285 285
286 main_view->contents_view()->SetShowState(ContentsView::SHOW_START_PAGE); 286 ContentsView* contents_view = main_view->contents_view();
287 main_view->contents_view()->Layout(); 287 contents_view->SetActivePage(
288 contents_view->GetPageIndexForNamedPage(ContentsView::SHOW_START_PAGE));
289 contents_view->Layout();
288 EXPECT_FALSE(main_view->search_box_view()->visible()); 290 EXPECT_FALSE(main_view->search_box_view()->visible());
289 EXPECT_TRUE(IsViewAtOrigin(start_page_view)); 291 EXPECT_TRUE(IsViewAtOrigin(start_page_view));
290 EXPECT_FALSE( 292 EXPECT_FALSE(IsViewAtOrigin(contents_view->apps_container_view()));
291 IsViewAtOrigin(main_view->contents_view()->apps_container_view()));
292 EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views())); 293 EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views()));
293 294
294 main_view->contents_view()->SetShowState(ContentsView::SHOW_APPS); 295 contents_view->SetActivePage(
295 main_view->contents_view()->Layout(); 296 contents_view->GetPageIndexForNamedPage(ContentsView::SHOW_APPS));
297 contents_view->Layout();
296 EXPECT_TRUE(main_view->search_box_view()->visible()); 298 EXPECT_TRUE(main_view->search_box_view()->visible());
297 EXPECT_FALSE(IsViewAtOrigin(start_page_view)); 299 EXPECT_FALSE(IsViewAtOrigin(start_page_view));
298 EXPECT_TRUE( 300 EXPECT_TRUE(IsViewAtOrigin(contents_view->apps_container_view()));
299 IsViewAtOrigin(main_view->contents_view()->apps_container_view()));
300 301
301 // Check tiles hide and show on deletion and addition. 302 // Check tiles hide and show on deletion and addition.
302 model->CreateAndAddItem("Test app"); 303 model->CreateAndAddItem("Test app");
303 EXPECT_EQ(4u, GetVisibleTileItemViews(start_page_view->tile_views())); 304 EXPECT_EQ(4u, GetVisibleTileItemViews(start_page_view->tile_views()));
304 model->DeleteItem(model->GetItemName(0)); 305 model->DeleteItem(model->GetItemName(0));
305 EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views())); 306 EXPECT_EQ(3u, GetVisibleTileItemViews(start_page_view->tile_views()));
306 } else { 307 } else {
307 EXPECT_EQ(NULL, start_page_view); 308 EXPECT_EQ(NULL, start_page_view);
308 } 309 }
309 310
(...skipping 169 matching lines...) Expand 10 before | Expand all | Expand 10 after
479 INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance, 480 INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance,
480 AppListViewTestAura, 481 AppListViewTestAura,
481 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END)); 482 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
482 483
483 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance, 484 INSTANTIATE_TEST_CASE_P(AppListViewTestDesktopInstance,
484 AppListViewTestDesktop, 485 AppListViewTestDesktop,
485 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END)); 486 ::testing::Range<int>(TEST_TYPE_START, TEST_TYPE_END));
486 487
487 } // namespace test 488 } // namespace test
488 } // namespace app_list 489 } // namespace app_list
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698