Chromium Code Reviews Chromium Code Reviews
Issue
317723005:
Refactor app list ContentsView to use page indices, not show states. (Closed)
DescriptionRefactor app list ContentsView to use page indices, not show states.
Renamed ShowState to NamedPage. It is now an enum reserved for built-in
launcher pages, for parts of the code that need hard-coded access to a
specific built-in page. A mapping from named pages to page indices is
provided, so pages can be accessed by named page. Not every page needs a
name.
Instead of remembering the current named page, it remembers the current
page index (an arbitrary int). This means:
- we now insert views in a sensible order for the experimental app list
(and use that order for the UI), instead of hard-coding the view order
the same way for both app list modes.
- we will be able to dynamically add pages to the launcher.
BUG=377381
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276194
Patch Set 1 #Patch Set 2 : Formatting. #Patch Set 3 : Rebase. #Patch Set 4 : Roll in a second refactor: everything is now view-index-based, not show-state-based. #Patch Set 5 : Update comments and method names. #Patch Set 6 : Rebase off CL 312213005 (much simpler). #Patch Set 7 : Various cleanup. #Patch Set 8 : Reorder views; rename ShowState to NamedPage. #Patch Set 9 : Renamed IsActiveNamedPage to IsNamedPageActive. #Patch Set 10 : Fixed AppListViewTest. #
Total comments: 12
Patch Set 11 : Respond to review (benwells). #Patch Set 12 : Use AddLauncherPage return value and avoid calling GetPageIndexForNamedPage. #Patch Set 13 : Renamed again, and rewrote comments for AddLauncherPage. #
Messages
Total messages: 9 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
