Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 317723003: Split image-currentsrc test into 3 separate tests (Closed)

Created:
6 years, 6 months ago by Yoav Weiss
Modified:
6 years, 6 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Split image-currentsrc test into 3 separate tests Following flakiness resulting from race conditions, I'm splitting the image-currentsrc test into 3 separate layout tests. BUG=380664 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175507

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -52 lines) Patch
M LayoutTests/TestExpectations View 1 chunk +0 lines, -2 lines 0 comments Download
D LayoutTests/http/tests/images/image-currentsrc.html View 1 chunk +0 lines, -30 lines 0 comments Download
A LayoutTests/http/tests/images/image-currentsrc-error.html View 1 chunk +16 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/images/image-currentsrc-error-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
D LayoutTests/http/tests/images/image-currentsrc-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
A + LayoutTests/http/tests/images/image-currentsrc-load.html View 2 chunks +0 lines, -11 lines 0 comments Download
A LayoutTests/http/tests/images/image-currentsrc-load-expected.txt View 1 chunk +6 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/images/image-currentsrc-redirect.html View 1 chunk +15 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/images/image-currentsrc-redirect-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Yoav Weiss
6 years, 6 months ago (2014-06-04 16:01:53 UTC) #1
Julien - ping for review
lgtm
6 years, 6 months ago (2014-06-04 16:34:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoav@yoav.ws/317723003/1
6 years, 6 months ago (2014-06-04 16:35:00 UTC) #3
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-04 17:47:10 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 18:47:15 UTC) #5
Message was sent while issue was closed.
Change committed as 175507

Powered by Google App Engine
This is Rietveld 408576698