DevTools: Show internal properties in object preview in console.

Source/core/inspector/InjectedScriptSource.js

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 1076 matching lines @@
     this.objectId = injectedScript._bind(object, objectGroupName);
     var subtype = injectedScript._subtype(object);
     if (subtype)
         this.subtype = subtype;
     var className = InjectedScriptHost.internalConstructorName(object);
     if (className)
         this.className = className;
     this.description = injectedScript._describe(object);
 
     if (generatePreview && (this.type === "object" || injectedScript._isHTMLAllCollection(object)))
-        this.preview = this._generatePreview(object, undefined, columnNames, isTable, false);
+        this.preview = this._generatePreview(object, undefined, columnNames, isTable);
 }
 
 InjectedScript.RemoteObject.prototype = {
     /**
      * @param {Object} object
      * @param {Array.<string>=} firstLevelKeys
      * @param {?Array.<string>=} secondLevelKeys
      * @param {boolean=} isTable
-     * @param {boolean=} isTableRow
      * @return {!RuntimeAgent.ObjectPreview} preview
      */
-    _generatePreview: function(object, firstLevelKeys, secondLevelKeys, isTable, isTableRow)
+    _generatePreview: function(object, firstLevelKeys, secondLevelKeys, isTable)
     {
         var preview = { __proto__: null };
         preview.lossless = true;
         preview.overflow = false;
         preview.properties = [];
 
         var firstLevelKeysCount = firstLevelKeys ? firstLevelKeys.length : 0;
 
         var propertiesThreshold = {
-            properties: (isTable || isTableRow) ? 1000 : max(5, firstLevelKeysCount),
-            indexes: (isTable || isTableRow) ? 1000 : max(100, firstLevelKeysCount)
+            properties: isTable ? 1000 : max(5, firstLevelKeysCount),
+            indexes: isTable ? 1000 : max(100, firstLevelKeysCount)
         };
 
         try {
             var descriptors = injectedScript._propertyDescriptors(object);
+            var internalProperties;
 
             if (firstLevelKeys) {
                 var nameToDescriptors = { __proto__: null };
                 for (var i = 0; i < descriptors.length; ++i) {
                     var descriptor = descriptors[i];
                     nameToDescriptors["#" + descriptor.name] = descriptor;
                 }
                 descriptors = [];
                 for (var i = 0; i < firstLevelKeys.length; ++i)
                     descriptors[i] = nameToDescriptors["#" + firstLevelKeys[i]];
             }
 
-            for (var i = 0; i < descriptors.length; ++i) {
+            for (var i = 0, n = descriptors.length + 1; i < n; ++i) {
                 if (propertiesThreshold.indexes < 0 || propertiesThreshold.properties < 0)
                     break;
 
                 var descriptor = descriptors[i];
+                if (i >= descriptors.length && !isTable) {
+                    // Add internal properties to preview.
+                    if (!internalProperties) {
+                        internalProperties = InjectedScriptHost.getInternalProperties(object) || [];
+                        n = descriptors.length + internalProperties.length;
+                        if (i >= n)
+                            break;
+                    }
+                    descriptor = nullifyObjectProto(internalProperties[i - descriptors.length]);
+                    descriptor.enumerable = true;
+                }
+
                 if (!descriptor)

[yurys, 2014/06/06 09:12:01]

Let's try to extract common part into a separate method.

[aandrey, 2014/06/06 09:28:41]

Done.

                     continue;
                 if (descriptor.wasThrown) {
                     preview.lossless = false;
                     continue;
                 }
                 if (!descriptor.enumerable && !descriptor.isOwn)
                     continue;
 
                 var name = descriptor.name;
                 if (name === "__proto__")
@@ skipping 23 matching lines @@
                 if (InjectedScript.primitiveTypes[type]) {
                     if (type === "string" && value.length > maxLength) {
                         value = this._abbreviateString(value, maxLength, true);
                         preview.lossless = false;
                     }
                     this._appendPropertyPreview(preview, { name: name, type: type, value: toStringDescription(value), __proto__: null }, propertiesThreshold);
                     continue;
                 }
 
                 if (secondLevelKeys === null || secondLevelKeys) {
-                    var subPreview = this._generatePreview(value, secondLevelKeys || undefined, undefined, false, isTable);
+                    var subPreview = this._generatePreview(value, secondLevelKeys || undefined, undefined, isTable);
                     var property = { name: name, type: type, valuePreview: subPreview, __proto__: null };
                     this._appendPropertyPreview(preview, property, propertiesThreshold);
                     if (!subPreview.lossless)
                         preview.lossless = false;
                     if (subPreview.overflow)
                         preview.overflow = true;
                     continue;
                 }
 
                 preview.lossless = false;
@@ skipping 445 matching lines @@
      */
     _logEvent: function(event)
     {
         inspectedWindow.console.log(event.type, event);
     }
 }
 
 injectedScript._commandLineAPIImpl = new CommandLineAPIImpl();
 return injectedScript;
 })