Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(37)

Issue 3177021: Update TSan to r2386.... (Closed)

Created:
10 years, 3 months ago by Timur Iskhodzhanov
Modified:
9 years, 5 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Update TSan to r2386. TEST=tried on bots a few times and fixed a couple of issues in TSan before creating this CL Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=56521

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -17 lines) Patch
M binaries/linux_x64/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/linux_x86/bin/valgrind-tsan.sh View Binary file 0 comments Download
M binaries/mac/bin/valgrind-tsan.sh View Binary file 0 comments Download
M scripts/build-tsan-for-chromium.sh View 1 2 chunks +5 lines, -17 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Timur Iskhodzhanov
10 years, 3 months ago (2010-08-18 12:44:49 UTC) #1
Alexander Potapenko
LGTM
10 years, 3 months ago (2010-08-18 12:49:42 UTC) #2
Timur Iskhodzhanov
Just for the record, TSan Mac is green and became 2 minutes faster after the ...
10 years, 3 months ago (2010-08-18 13:26:22 UTC) #3
Timur Iskhodzhanov
10 years, 3 months ago (2010-08-18 15:34:21 UTC) #4
Linux x64: -6.5 minutes
http://build.chromium.org/buildbot/waterfall.fyi/builders/Linux%20Tests%20(ts...

Linux x86: -12 minutes
http://build.chromium.org/buildbot/memory/builders/Linux%20Tests%20(tsan)/bui...

Summary: 10-15% faster, as expected

On 2010/08/18 13:26:22, Timur Iskhodzhanov wrote:
> Just for the record,
> TSan Mac is green and became 2 minutes faster after the update
>
http://build.chromium.org/buildbot/memory/builders/Chromium%2520Mac%2520%28ts...

Powered by Google App Engine
This is Rietveld 408576698