Issue 3177013: Backport http://code.google.com/p/v8/source/detail?r=5261 to 2.2.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3177013: Backport http://code.google.com/p/v8/source/detail?r=5261 to 2.2. (Closed)

Created:
10 years, 4 months ago by antonm

Modified:
9 years, 4 months ago

Reviewers:
Søren Thygesen Gjesse, Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/2.2/

Visibility:
Public.

Description

Backport http://code.google.com/p/v8/source/detail?r=5261 to 2.2. Committed: http://code.google.com/p/v8/source/detail?r=5269

Patch Set 1 #

Created: 10 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -2 lines)			Patch
M	src/api.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	src/heap.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/heap.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	src/platform.h	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/platform-nullos.cc	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	src/platform-posix.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/platform-win32.cc	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	src/version.cc	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

antonm

Mads, Søren, now comes the backport. I am not going to commit unless I got ...

10 years, 4 months ago (2010-08-13 11:29:28 UTC) #1

Mads Ager (chromium)

10 years, 4 months ago (2010-08-13 11:34:31 UTC) #2

LGTM

I see no issue with pushing this to the 2.2 branch. This code is only exercised
in OOM situations where we are most likely crashing a renderer in any case.

Expand Messages | Collapse Messages