Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(806)

Unified Diff: ui/compositor/layer.h

Issue 317663005: Scale the ALPHA_THRESHOLD filter's region based on the device scale factor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert surface filter changes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | ui/compositor/layer.cc » ('j') | ui/compositor/layer.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/layer.h
diff --git a/ui/compositor/layer.h b/ui/compositor/layer.h
index 2b0d9138361dd46eabb0dbe199716c63c2256f3e..378478eb3354c84e89534fa675368f8648a2bb98 100644
--- a/ui/compositor/layer.h
+++ b/ui/compositor/layer.h
@@ -374,6 +374,8 @@ class COMPOSITOR_EXPORT Layer
void RecomputeDrawsContentAndUVRect();
void RecomputePosition();
+ void RecomputeAlphaShape();
Wez 2014/06/08 00:55:54 Add an explanatory comment?
garykac 2014/06/09 21:30:00 Done.
+
// Set all filters which got applied to the layer.
void SetLayerFilters();
@@ -435,7 +437,11 @@ class COMPOSITOR_EXPORT Layer
// Width of the border in pixels, where the scaling is blended.
int zoom_inset_;
- // Shape of the window.
+ // The alpha shape specifies the area that is visible (and matches the area
+ // that accepts input events).
+ // |raw_alpha_shape_| is the shape as specified and |alpha_shape_| is the
+ // shape after being adjusted by the |device_scale_factor_|.
+ scoped_ptr<SkRegion> raw_alpha_shape_;
Wez 2014/06/08 00:55:54 nit: Would |dips_alpha_shape_| and |device_alpha_s
garykac 2014/06/09 21:29:59 I updated raw_ to dips_ and updated the comment.
scoped_ptr<SkRegion> alpha_shape_;
std::string name_;
« no previous file with comments | « no previous file | ui/compositor/layer.cc » ('j') | ui/compositor/layer.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698