cc/output/filter_operation.cc - Issue 317663005: Scale the ALPHA_THRESHOLD filter's region based on the device scale factor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/output/filter_operation.cc

Issue 317663005: Scale the ALPHA_THRESHOLD filter's region based on the device scale factor. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Use SkMatrix when creating AlphaFilter Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: cc/output/filter_operation.cc

diff --git a/cc/output/filter_operation.cc b/cc/output/filter_operation.cc

index 7682853b2e29f202085ee191965e22a503c75986..1ebdcdeb737928f44ce3c4d2209489c9b77acce2 100644

--- a/cc/output/filter_operation.cc

+++ b/cc/output/filter_operation.cc

@@ -249,7 +249,8 @@ FilterOperation FilterOperation::Blend(const FilterOperation* from,

from_op.outer_threshold(),

to_op.outer_threshold()),

to_op.type()));

- blended_filter.set_region(to_op.region());

+ const FilterOperation& copy_op = progress > 0.5 ? to_op : from_op;

danakj 2014/07/11 16:08:22 is this needed?

+ blended_filter.set_region(copy_op.region());

}

return blended_filter;

« cc/layers/render_surface_impl.cc ('K') | « cc/layers/render_surface_impl.cc ('k') | cc/output/filter_operations_unittest.cc » ('j') | cc/quads/render_pass_draw_quad.h » ('J')