Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 317663003: Revert of Move Dashing filterPath to a dashing utils file (Closed)

Created:
6 years, 6 months ago by egdaniel
Modified:
6 years, 6 months ago
Reviewers:
bsalomon, rmistry, reed1
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Move Dashing filterPath to a dashing utils file (https://codereview.chromium.org/314623004/) Reason for revert: Need to create utils.gypi file and update chrome Original issue's description: > Move Dashing filterPath to a dashing utils file > > From inside GrContext, we have a need to create an SkPath an original path and > some dashing info. We do not have access to the original path effect so we need > a way to make the FilterPath function accessible outside of the effect. So I moved > the core filterPath code (and all need helper functions) out of SkDashPathEffect > and created a SkDashPath in utils to store these helper functions. > > BUG=skia: > > Committed: https://skia.googlesource.com/skia/+/576dcdc793a762ec63fbecdbfd5768066b548fe5 TBR=bsalomon@google.com,reed@google.com,rmistry@google.com NOTREECHECKS=true NOTRY=true BUG=skia: Committed: https://skia.googlesource.com/skia/+/90b8cafb6a362bb5d5cca03b66ea57e97b9b43f2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+304 lines, -375 lines) Patch
M gyp/utils.gyp View 1 chunk +0 lines, -2 lines 0 comments Download
M include/effects/SkDashPathEffect.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/effects/SkDashPathEffect.cpp View 3 chunks +302 lines, -13 lines 0 comments Download
D src/utils/SkDashPath.cpp View 1 chunk +0 lines, -328 lines 0 comments Download
D src/utils/SkDashPathPriv.h View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
egdaniel
Created Revert of Move Dashing filterPath to a dashing utils file
6 years, 6 months ago (2014-06-04 16:58:27 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/egdaniel@google.com/317663003/1
6 years, 6 months ago (2014-06-04 16:59:02 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 16:59:12 UTC) #3
Message was sent while issue was closed.
Change committed as 90b8cafb6a362bb5d5cca03b66ea57e97b9b43f2

Powered by Google App Engine
This is Rietveld 408576698