Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Unified Diff: runtime/vm/object_test.cc

Issue 317643004: Unify handling of identical(NaN, NaN) between generated code and Dart API. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/number_identity2_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
===================================================================
--- runtime/vm/object_test.cc (revision 37108)
+++ runtime/vm/object_test.cc (working copy)
@@ -524,10 +524,26 @@
EXPECT(!dbl1.OperatorEquals(Smi::Handle(Smi::New(3))));
EXPECT(!dbl1.OperatorEquals(Double::Handle()));
const Double& nan0 = Double::Handle(Double::New(NAN));
+ EXPECT(isnan(nan0.value()));
EXPECT(nan0.IsIdenticalTo(nan0));
EXPECT(nan0.CanonicalizeEquals(nan0));
EXPECT(!nan0.OperatorEquals(nan0));
- // TODO(18738): Test bitwise different NaNs after agreement on spec.
+ const Double& nan = Double::Handle(Double::New(0.0/0.0));
+ const Double& inf = Double::Handle(Double::New(1.0/0.0));
+ EXPECT(isnan(nan.value()));
+ EXPECT(!isnan(inf.value()));
+ EXPECT(!nan.IsIdenticalTo(inf));
+ EXPECT(!nan.CanonicalizeEquals(inf));
+ EXPECT(!nan.OperatorEquals(inf));
+ const Double& nan1 = Double::Handle(
+ Double::New(bit_cast<double>(kMaxUint64 - 0)));
+ const Double& nan2 = Double::Handle(
+ Double::New(bit_cast<double>(kMaxUint64 - 1)));
+ EXPECT(isnan(nan1.value()));
+ EXPECT(isnan(nan2.value()));
+ EXPECT(!nan1.IsIdenticalTo(nan2));
+ EXPECT(!nan1.CanonicalizeEquals(nan2));
+ EXPECT(!nan1.OperatorEquals(nan2));
}
{
const String& dbl_str0 = String::Handle(String::New("bla"));
« no previous file with comments | « runtime/vm/object.cc ('k') | tests/language/number_identity2_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698