Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 317613005: Adds Irish keyboard to linux_chromeos. (Closed)

Created:
6 years, 6 months ago by Shu Chen
Modified:
6 years, 6 months ago
Reviewers:
Seigo Nonaka
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, nona+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, nkostylev+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Adds Irish keyboard to linux_chromeos, and fixes some other xkb names. BUG=364712 TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=274803

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome/app/chromeos_strings.grdp View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/input_method/input_method_manager_impl.cc View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/input_method/input_method_util.cc View 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Shu Chen
Nona, can you please review this cl? Thanks
6 years, 6 months ago (2014-06-04 03:17:10 UTC) #1
Seigo Nonaka
lgtm
6 years, 6 months ago (2014-06-04 06:34:17 UTC) #2
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-04 07:31:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/317613005/20001
6 years, 6 months ago (2014-06-04 07:32:46 UTC) #4
Shu Chen
The CQ bit was unchecked by shuchen@chromium.org
6 years, 6 months ago (2014-06-04 08:54:14 UTC) #5
Shu Chen
The CQ bit was checked by shuchen@chromium.org
6 years, 6 months ago (2014-06-04 08:54:42 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/shuchen@chromium.org/317613005/40001
6 years, 6 months ago (2014-06-04 09:03:11 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-04 13:10:21 UTC) #8
Message was sent while issue was closed. 
Change committed as 274803

Powered by Google App Engine
This is Rietveld 408576698